From e300c37b2d564a799b9f014bc78f7f8c0c86f52e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabian=20Gra=C3=9Fl?= Date: Fri, 30 Oct 2026 12:11:53 +0100 Subject: [PATCH] The suite page says where the presentation's fixes come from MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The page said the presentation package pins `phpoffice/phppresentation` to a commit on `dev-master`, and that `composer validate` runs without `--strict` there because the pin is a warning. Neither is true: the package requires `~1.2.0`, which is a range of tags, and `composer validate --strict` passes. The fixes the package needs are not in that release, so they come from a patch the library applies to the installed package — the patch its `extra.patches` names, and the one its README explains. The page says that now, and points at the README rather than repeating how the patch is applied. Both sentences are in the FORBIDDEN map, so a page that says either of them again is a failure. --- content/suite/index.md | 8 +++++--- tools/check-command-line.php | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/content/suite/index.md b/content/suite/index.md index 6882273..c405c77 100644 --- a/content/suite/index.md +++ b/content/suite/index.md @@ -88,9 +88,11 @@ project on 7.2 or 7.3 cannot install the pair together. `ext-imagick` is in `suggest` for both, and buys SVG. See [Images](/images/). -The presentation package pins `phpoffice/phppresentation` to a **commit on `dev-master`**, not a -tag, because the fixes it needs are not in a release. That is why `composer validate` runs without -`--strict` there: the pin is a warning, and the warning is the point. +The presentation package requires `phpoffice/phppresentation` at `~1.2.0` — a range of tags, and +`composer validate --strict` passes there. The fixes it needs are not in that release, so they +come from a **patch the library applies to the installed package**: a project that installs the +package has to allow the `cweagans/composer-patches` plugin for the patch to land. The library's +[README](https://github.com/markdown-office/markdown-presentation#installation) has the details. ## The conventions they share diff --git a/tools/check-command-line.php b/tools/check-command-line.php index 8cc1966..394fa34 100644 --- a/tools/check-command-line.php +++ b/tools/check-command-line.php @@ -103,6 +103,8 @@ 'the presentation index claimed to use every frontmatter key' => 'Every frontmatter key on a deck', 'the Word page said the container form of a drawn name is claimed' => 'the body is **silently dropped**', 'the errors page called a loss by a method it does not have' => '$loss->feature()', + 'the suite page said the presentation pins a commit on dev-master' => 'to a **commit on `dev-master`**', + 'the suite page said the presentation validates without --strict' => '`composer validate` runs without', ]; /**