tests and fixes

Author: KSemenenko

AGENTS.md

@@ -387,6 +387,7 @@ Ask first:
 
 ### Likes
 
+- Keep regression coverage tied to real operator flows: when agent creation changes, tests should cover creating an agent, choosing a valid provider model, and sending at least one message through the resulting session path.
 - Follow the canonical MCAF tutorial when bootstrapping or upgrading the agent workflow.
 - Commit cohesive code-change batches promptly while debugging, especially before switching focus or starting long verification runs, so the branch state stays inspectable and pushable.
 - After opening or updating a PR, create a fresh working branch before continuing with the next slice of work so follow-up changes do not pile onto the already-reviewed branch.

DotPilot.Core/AgentBuilder/Services/AgentPromptDraftGenerator.cs

@@ -111,6 +111,7 @@ private async ValueTask<ProviderStatusDescriptor> ResolvePreferredProviderAsync(
                 AgentProviderStatus.Disabled,
                 "Provider is disabled for local agent creation.",
                 AgentSessionDefaults.GetDefaultModel(AgentProviderKind.Debug),
+                [AgentSessionDefaults.GetDefaultModel(AgentProviderKind.Debug)],
                 AgentSessionDefaults.GetDefaultModel(AgentProviderKind.Debug),
                 false,
                 false,

DotPilot.Core/ChatSessions/Commands/CreateSessionCommand.cs

@@ -1,5 +1,5 @@
-using ManagedCode.Communication.Commands;
 using DotPilot.Core.ControlPlaneDomain;
+using ManagedCode.Communication.Commands;
 
 namespace DotPilot.Core.ChatSessions.Commands;
 

DotPilot.Core/ChatSessions/Commands/SendSessionMessageCommand.cs

@@ -1,6 +1,6 @@
 using System.Globalization;
-using ManagedCode.Communication.Commands;
 using DotPilot.Core.ControlPlaneDomain;
+using ManagedCode.Communication.Commands;
 
 namespace DotPilot.Core.ChatSessions.Commands;
 

DotPilot.Core/ChatSessions/Contracts/AgentSessionContracts.cs

@@ -19,6 +19,7 @@ public sealed record ProviderStatusDescriptor(
     AgentProviderStatus Status,
     string StatusSummary,
     string SuggestedModelName,
+    IReadOnlyList<string> SupportedModelNames,
     string? InstalledVersion,
     bool IsEnabled,
     bool CanCreateAgents,

DotPilot.Core/ChatSessions/Execution/AgentSessionService.cs

@@ -157,9 +157,11 @@ public async ValueTask<Result<AgentProfileSummary>> CreateAgentAsync(
             {
                 Id = Guid.CreateVersion7(),
                 Name = agentName,
+                Role = AgentProfileSchemaDefaults.DefaultRole,
                 ProviderKind = (int)command.ProviderKind,
                 ModelName = modelName,
                 SystemPrompt = systemPrompt,
+                CapabilitiesJson = AgentProfileSchemaDefaults.EmptyCapabilitiesJson,
                 CreatedAt = createdAt,
             };
 
@@ -719,6 +721,7 @@ private async Task EnsureInitializedAsync(CancellationToken cancellationToken)
             AgentSessionServiceLog.InitializationStarted(logger);
             await using var dbContext = await dbContextFactory.CreateDbContextAsync(cancellationToken);
             await dbContext.Database.EnsureCreatedAsync(cancellationToken);
+            await AgentProfileSchemaCompatibilityEnsurer.EnsureAsync(dbContext, cancellationToken);
             await EnsureDefaultProviderAndAgentAsync(dbContext, cancellationToken);
             _initialized = true;
             AgentSessionServiceLog.InitializationCompleted(logger);
@@ -776,9 +779,11 @@ record => record.ProviderKind == (int)AgentProviderKind.Debug,
         {
             Id = Guid.CreateVersion7(),
             Name = AgentSessionDefaults.SystemAgentName,
+            Role = AgentProfileSchemaDefaults.DefaultRole,
             ProviderKind = (int)providerKind,
             ModelName = AgentSessionDefaults.GetDefaultModel(providerKind),
             SystemPrompt = AgentSessionDefaults.SystemAgentPrompt,
+            CapabilitiesJson = AgentProfileSchemaDefaults.EmptyCapabilitiesJson,
             CreatedAt = timeProvider.GetUtcNow(),
         };
 

DotPilot.Core/ChatSessions/Persistence/Configuration/AgentProfileSchemaDefaults.cs

@@ -0,0 +1,9 @@
+namespace DotPilot.Core.ChatSessions;
+
+internal static class AgentProfileSchemaDefaults
+{
+    // Legacy SQLite stores still require these columns even though the current UI no longer edits them.
+    public const int DefaultRole = 4;
+
+    public const string EmptyCapabilitiesJson = "[]";
+}

DotPilot.Core/ChatSessions/Persistence/Models/LocalAgentSessionRecords.cs

@@ -6,12 +6,16 @@ internal sealed class AgentProfileRecord
 
     public string Name { get; set; } = string.Empty;
 
+    public int Role { get; set; }
+
     public int ProviderKind { get; set; }
 
     public string ModelName { get; set; } = string.Empty;
 
     public string SystemPrompt { get; set; } = string.Empty;
 
+    public string CapabilitiesJson { get; set; } = AgentProfileSchemaDefaults.EmptyCapabilitiesJson;
+
     public DateTimeOffset CreatedAt { get; set; }
 }
 

DotPilot.Core/ChatSessions/Persistence/Services/AgentProfileSchemaCompatibilityEnsurer.cs

@@ -0,0 +1,77 @@
+using System.Data;
+using Microsoft.EntityFrameworkCore;
+
+namespace DotPilot.Core.ChatSessions;
+
+internal static class AgentProfileSchemaCompatibilityEnsurer
+{
+    private const string AgentProfilesTableName = "AgentProfiles";
+    private const string RoleColumnName = "Role";
+    private const string CapabilitiesJsonColumnName = "CapabilitiesJson";
+
+    public static async Task EnsureAsync(LocalAgentSessionDbContext dbContext, CancellationToken cancellationToken)
+    {
+        ArgumentNullException.ThrowIfNull(dbContext);
+
+        if (!dbContext.Database.IsSqlite())
+        {
+            return;
+        }
+
+        var existingColumns = await ReadColumnNamesAsync(dbContext, cancellationToken);
+        if (!existingColumns.Contains(RoleColumnName, StringComparer.OrdinalIgnoreCase))
+        {
+            await dbContext.Database.ExecuteSqlRawAsync(
+                $"""
+                 ALTER TABLE "{AgentProfilesTableName}"
+                 ADD COLUMN "{RoleColumnName}" INTEGER NOT NULL DEFAULT {AgentProfileSchemaDefaults.DefaultRole};
+                 """,
+                cancellationToken);
+        }
+
+        if (!existingColumns.Contains(CapabilitiesJsonColumnName, StringComparer.OrdinalIgnoreCase))
+        {
+            await dbContext.Database.ExecuteSqlRawAsync(
+                $"""
+                 ALTER TABLE "{AgentProfilesTableName}"
+                 ADD COLUMN "{CapabilitiesJsonColumnName}" TEXT NOT NULL DEFAULT '{AgentProfileSchemaDefaults.EmptyCapabilitiesJson}';
+                 """,
+                cancellationToken);
+        }
+    }
+
+    private static async Task<HashSet<string>> ReadColumnNamesAsync(
+        LocalAgentSessionDbContext dbContext,
+        CancellationToken cancellationToken)
+    {
+        var connection = dbContext.Database.GetDbConnection();
+        var shouldCloseConnection = connection.State != ConnectionState.Open;
+        if (shouldCloseConnection)
+        {
+            await connection.OpenAsync(cancellationToken);
+        }
+
+        try
+        {
+            await using var command = connection.CreateCommand();
+            command.CommandText = $"""PRAGMA table_info("{AgentProfilesTableName}")""";
+
+            HashSet<string> columns = new(StringComparer.OrdinalIgnoreCase);
+            await using var reader = await command.ExecuteReaderAsync(cancellationToken);
+            var nameOrdinal = reader.GetOrdinal("name");
+            while (await reader.ReadAsync(cancellationToken))
+            {
+                columns.Add(reader.GetString(nameOrdinal));
+            }
+
+            return columns;
+        }
+        finally
+        {
+            if (shouldCloseConnection)
+            {
+                await connection.CloseAsync();
+            }
+        }
+    }
+}

DotPilot.Core/ChatSessions/Persistence/Storage/LocalAgentSessionDbContext.cs

@@ -19,8 +19,13 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
         {
             entity.HasKey(record => record.Id);
             entity.Property(record => record.Name).IsRequired();
+            entity.Property(record => record.Role)
+                .HasDefaultValue(AgentProfileSchemaDefaults.DefaultRole);
             entity.Property(record => record.ModelName).IsRequired();
             entity.Property(record => record.SystemPrompt).IsRequired();
+            entity.Property(record => record.CapabilitiesJson)
+                .HasDefaultValue(AgentProfileSchemaDefaults.EmptyCapabilitiesJson)
+                .IsRequired();
         });
 
         modelBuilder.Entity<SessionRecord>(entity =>