fix: harden windows sqlite test cleanup

Author: KSemenenko

DotPilot.Tests/ChatSessions/Execution/AgentSessionServiceTests.cs

@@ -13,6 +13,8 @@ public sealed class AgentSessionServiceTests
 {
     private const int LegacyDefaultRole = 4;
     private const string LegacyEmptyCapabilitiesJson = "[]";
+    private const int DeleteRetryCount = 20;
+    private static readonly TimeSpan DeleteRetryDelay = TimeSpan.FromMilliseconds(250);
 
     [Test]
     public async Task GetWorkspaceAsyncSeedsDefaultSystemAgentForANewStore()
@@ -646,7 +648,7 @@ private async ValueTask DisposeAsyncCore()
 
     private static async Task DeleteDirectoryWithRetryAsync(string path)
     {
-        for (var attempt = 0; attempt < 5; attempt++)
+        for (var attempt = 0; attempt < DeleteRetryCount; attempt++)
         {
             if (!Directory.Exists(path))
             {
@@ -658,13 +660,13 @@ private static async Task DeleteDirectoryWithRetryAsync(string path)
                 Directory.Delete(path, recursive: true);
                 return;
             }
-            catch (IOException) when (attempt < 4)
+            catch (IOException) when (attempt < DeleteRetryCount - 1)
             {
-                await Task.Delay(100);
+                await Task.Delay(DeleteRetryDelay);
             }
-            catch (UnauthorizedAccessException) when (attempt < 4)
+            catch (UnauthorizedAccessException) when (attempt < DeleteRetryCount - 1)
             {
-                await Task.Delay(100);
+                await Task.Delay(DeleteRetryDelay);
             }
         }
     }

DotPilot.Tests/ChatSessions/Persistence/AgentSessionPersistenceTests.cs

@@ -9,6 +9,8 @@ namespace DotPilot.Tests.ChatSessions;
 
 public sealed class AgentSessionPersistenceTests
 {
+    private const int DeleteRetryCount = 20;
+    private static readonly TimeSpan DeleteRetryDelay = TimeSpan.FromMilliseconds(250);
     private static readonly JsonSerializerOptions HistorySerializerOptions = new()
     {
         TypeInfoResolver = new DefaultJsonTypeInfoResolver(),
@@ -82,7 +84,7 @@ await DrainAsync(
         }
         finally
         {
-            DeleteDirectory(root);
+            await DeleteDirectoryAsync(root);
         }
     }
 
@@ -152,11 +154,28 @@ private static string CreateRootPath()
             Guid.NewGuid().ToString("N", System.Globalization.CultureInfo.InvariantCulture));
     }
 
-    private static void DeleteDirectory(string path)
+    private static async Task DeleteDirectoryAsync(string path)
     {
-        if (Directory.Exists(path))
+        for (var attempt = 0; attempt < DeleteRetryCount; attempt++)
         {
-            Directory.Delete(path, recursive: true);
+            if (!Directory.Exists(path))
+            {
+                return;
+            }
+
+            try
+            {
+                Directory.Delete(path, recursive: true);
+                return;
+            }
+            catch (IOException) when (attempt < DeleteRetryCount - 1)
+            {
+                await Task.Delay(DeleteRetryDelay);
+            }
+            catch (UnauthorizedAccessException) when (attempt < DeleteRetryCount - 1)
+            {
+                await Task.Delay(DeleteRetryDelay);
+            }
         }
     }
 

DotPilot.Tests/Providers/Services/CodexCliTestScope.cs

@@ -5,6 +5,8 @@ namespace DotPilot.Tests.Providers;
 
 internal sealed class CodexCliTestScope : IDisposable
 {
+    private const int DeleteRetryCount = 20;
+    private static readonly TimeSpan DeleteRetryDelay = TimeSpan.FromMilliseconds(250);
     private readonly string rootPath;
     private readonly string? originalPath;
     private readonly string? originalHome;
@@ -54,10 +56,7 @@ public void Dispose()
         Environment.SetEnvironmentVariable("PATH", originalPath);
         Environment.SetEnvironmentVariable("HOME", originalHome);
         Environment.SetEnvironmentVariable("USERPROFILE", originalUserProfile);
-        if (Directory.Exists(rootPath))
-        {
-            Directory.Delete(rootPath, recursive: true);
-        }
+        DeleteDirectoryWithRetry(rootPath);
 
         disposed = true;
     }
@@ -232,4 +231,29 @@ private void WriteCommand(string commandName, string commandBody)
             UnixFileMode.OtherRead |
             UnixFileMode.OtherExecute);
     }
+
+    private static void DeleteDirectoryWithRetry(string path)
+    {
+        for (var attempt = 0; attempt < DeleteRetryCount; attempt++)
+        {
+            if (!Directory.Exists(path))
+            {
+                return;
+            }
+
+            try
+            {
+                Directory.Delete(path, recursive: true);
+                return;
+            }
+            catch (IOException) when (attempt < DeleteRetryCount - 1)
+            {
+                System.Threading.Thread.Sleep(DeleteRetryDelay);
+            }
+            catch (UnauthorizedAccessException) when (attempt < DeleteRetryCount - 1)
+            {
+                System.Threading.Thread.Sleep(DeleteRetryDelay);
+            }
+        }
+    }
 }

DotPilot.Tests/Workspace/Services/StartupWorkspaceHydrationTests.cs

@@ -7,6 +7,9 @@ namespace DotPilot.Tests.Workspace;
 [NonParallelizable]
 public sealed class StartupWorkspaceHydrationTests
 {
+    private const int DeleteRetryCount = 20;
+    private static readonly TimeSpan DeleteRetryDelay = TimeSpan.FromMilliseconds(250);
+
     [Test]
     public async Task EnsureHydratedAsyncWarmsProviderStatusForSubsequentWorkspaceReads()
     {
@@ -107,7 +110,7 @@ public ValueTask DisposeAsync()
 
     private static async Task DeleteDirectoryWithRetryAsync(string path)
     {
-        for (var attempt = 0; attempt < 5; attempt++)
+        for (var attempt = 0; attempt < DeleteRetryCount; attempt++)
         {
             if (!Directory.Exists(path))
             {
@@ -119,13 +122,13 @@ private static async Task DeleteDirectoryWithRetryAsync(string path)
                 Directory.Delete(path, recursive: true);
                 return;
             }
-            catch (IOException) when (attempt < 4)
+            catch (IOException) when (attempt < DeleteRetryCount - 1)
             {
-                await Task.Delay(100);
+                await Task.Delay(DeleteRetryDelay);
             }
-            catch (UnauthorizedAccessException) when (attempt < 4)
+            catch (UnauthorizedAccessException) when (attempt < DeleteRetryCount - 1)
             {
-                await Task.Delay(100);
+                await Task.Delay(DeleteRetryDelay);
             }
         }
     }