Skip to content

Commit acb289d

Browse files
committed
Removed ResultState and renamed methods
1 parent 9b0119f commit acb289d

5 files changed

Lines changed: 33 additions & 59 deletions

File tree

Directory.Build.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1414
<PackageReadmeFile>README.md</PackageReadmeFile>
1515
<Product>Managed Code - Communication</Product>
16-
<Version>0.0.3</Version>
17-
<PackageVersion>0.0.3</PackageVersion>
16+
<Version>0.0.4</Version>
17+
<PackageVersion>0.0.4</PackageVersion>
1818
</PropertyGroup>
1919
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
2020
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>

ManagedCode.Communication/Result.cs

Lines changed: 21 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -4,59 +4,50 @@ namespace ManagedCode.Communication;
44

55
public class Result
66
{
7-
public Result(bool isSucceeded, ResultState status, Exception? error)
7+
public bool IsSuccess { get; }
8+
public bool IsError => !IsSuccess;
9+
public Exception? Error { get; }
10+
11+
public Result(bool isSuccess, Exception? error)
812
{
9-
IsSucceeded = isSucceeded;
10-
Status = status;
13+
IsSuccess = isSuccess;
1114
Error = error;
1215
}
1316

14-
public Result(bool isSucceeded, ResultState status)
17+
public Result(bool isSuccess)
1518
{
16-
IsSucceeded = isSucceeded;
17-
Status = status;
19+
IsSuccess = isSuccess;
1820
Error = null;
1921
}
2022

21-
public Result(Exception? error, ResultState status)
23+
public Result(Exception? error)
2224
{
23-
IsSucceeded = false;
25+
IsSuccess = false;
2426
Error = error;
25-
Status = status;
2627
}
2728

28-
public bool IsSucceeded { get; }
29-
public bool IsError => !IsSucceeded;
30-
public Exception? Error { get; }
31-
public ResultState Status { get; }
32-
33-
public static Result Succeeded(ResultState status = ResultState.Success)
29+
public static Result Succeed()
3430
{
35-
return new Result(true, status);
36-
}
37-
38-
public static Result<T> Succeeded<T>(T result, ResultState status = ResultState.Success)
39-
{
40-
return new Result<T>(true, result, status);
31+
return new Result(true);
4132
}
4233

43-
public static Result Failed(ResultState status, Exception? error = null)
34+
public static Result<T> Succeed<T>(T result)
4435
{
45-
return new Result(error, status);
36+
return new Result<T>(true, result);
4637
}
4738

48-
public static Result Failed(Exception? error, ResultState status = ResultState.Failed)
39+
public static Result Fail(Exception? error)
4940
{
50-
return new Result(error, status);
41+
return new Result(error);
5142
}
52-
53-
public static Result<T> Failed<T>(T result, Exception? error, ResultState status = ResultState.Success)
43+
44+
public static Result<T> Fail<T>(T result, Exception? error)
5445
{
55-
return new Result<T>(true, result, status);
46+
return new Result<T>(true, result);
5647
}
5748

58-
public static Result Failed()
49+
public static Result Fail()
5950
{
60-
return new Result(null, ResultState.Failed);
51+
return new Result(null);
6152
}
6253
}

ManagedCode.Communication/ResultExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ public static class ResultExtensions
66
{
77
public static Result<T> ToSucceededResult<T>(this T value)
88
{
9-
return new Result<T>(true, value, ResultState.Success);
9+
return new Result<T>(true, value);
1010
}
1111

1212
public static Task<Result<T>> AsTask<T>(this Result<T> value)

ManagedCode.Communication/ResultState.cs

Lines changed: 0 additions & 7 deletions
This file was deleted.

ManagedCode.Communication/ResultT.cs

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,39 +4,29 @@ namespace ManagedCode.Communication;
44

55
public class Result<T> : Result
66
{
7-
protected Result(Exception? error, ResultState status) : base(error, status)
8-
{
9-
}
7+
public T? Value { get; }
108

11-
public Result(bool isSucceeded, T value, ResultState status, Exception? error) : base(isSucceeded, status, error)
9+
protected Result(Exception? error) : base(error)
1210
{
13-
Value = value;
1411
}
1512

16-
public Result(bool isSucceeded, T value, ResultState status) : base(isSucceeded, status)
13+
public Result(bool isSuccess, T value, Exception? error) : base(isSuccess, error)
1714
{
1815
Value = value;
1916
}
2017

21-
public T? Value { get; }
22-
23-
public static Result<T> Succeeded(T content, ResultState status = ResultState.Success)
24-
{
25-
return new Result<T>(true, content, status);
26-
}
27-
28-
public new static Result<T> Failed(ResultState status, Exception? error = null)
18+
public Result(bool isSuccess, T value) : base(isSuccess)
2919
{
30-
return new Result<T>(error, status);
20+
Value = value;
3121
}
3222

33-
public new static Result<T> Failed(Exception? error, ResultState status = ResultState.Failed)
23+
public static Result<T> Succeed(T content)
3424
{
35-
return new Result<T>(error, status);
25+
return new Result<T>(true, content);
3626
}
3727

38-
public new static Result<T> Failed()
28+
public new static Result<T> Fail()
3929
{
40-
return new Result<T>(null, ResultState.Failed);
30+
return new Result<T>(null);
4131
}
4232
}

0 commit comments

Comments
 (0)