smartcontract/sdk: skip preflight simulation when submitting transactions#3750
Merged
Conversation
elitegreg
force-pushed
the
gm/no-simulation
branch
from
54215e4 to
86fc8f8
Compare
elitegreg
force-pushed
the
gm/no-simulation
branch
from
60be3b3 to
86fc8f8
Compare
…ions Previously DZClient::execute_transaction_inner ran simulate_transaction before send_and_confirm_transaction, which itself preflights by default, so every successful tx paid for two simulations. Submit with skip_preflight=true and recover program logs on the failure path via get_transaction, preserving the SimulationError / SimulationTransactionError shape for callers.
elitegreg
force-pushed
the
gm/no-simulation
branch
from
86fc8f8 to
b273b43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
simulate_transactioncall inDZClient::execute_transaction_inner. Previously every successful tx was simulated twice (once here, then again bysend_and_confirm_transaction's default preflight); now it's submitted once.RpcSendTransactionConfig { skip_preflight: true }viasend_and_confirm_transaction_with_spinner_and_config, eliminating preflight entirely.TransactionErrorfromClientErrorKind::TransactionErrororSendTransactionPreflightFailure, fetch program logs viaget_transaction_with_config, and surface them via the sameSimulationError/SimulationTransactionErrortypes so callers and CLI output are unchanged.get_transactionfetch is only hit on the cold path.Diff Breakdown
Single-file refactor of the transaction submission path in the Rust SDK.
Key files (click to expand)
smartcontract/sdk/rs/src/client.rs— rewritesexecute_transaction_innerto skip preflight and recover program logs fromget_transactionon the failure path.Testing Verification
cargo test -p doublezero_sdk --lib— all 147 unit tests pass.cargo clippy -p doublezero_sdk -- -Dclippy::all -Dwarningsclean.DoubleZeroErrormapping is intact.