Skip to content

Commit 15892de

Browse files
authored
Merge pull request #10 from im-kulikov/000-cleanup-code
[FIX] Cleanup code
2 parents 00873ad + 2e7c14c commit 15892de

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

dbr_go18_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ package dbr
44

55
import (
66
"context"
7+
"database/sql"
78
"testing"
89

910
"github.com/mailru/dbr/dialect"
10-
11-
"database/sql"
1211
"github.com/stretchr/testify/assert"
1312
)
1413

load.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ func mapExtractor(columns []string, value reflect.Value) []interface{} {
109109
value.Set(reflect.MakeMap(value.Type()))
110110
}
111111
m := value.Convert(typeKeyValueMap).Interface().(keyValueMap)
112-
var ptr []interface{}
112+
var ptr = make([]interface{}, 0, len(columns))
113113
for _, c := range columns {
114114
ptr = append(ptr, &kvScanner{column: c, m: m})
115115
}

load_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ func TestLoad(t *testing.T) {
3131
}
3232

3333
for _, tc := range testcases {
34+
var values []driver.Value
3435
session, dbmock := newSessionMock()
35-
values := []driver.Value{}
3636
for _, c := range tc.columns {
3737
values = append(values, c)
3838
}

types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,11 +205,11 @@ func (n *NullTime) Scan(value interface{}) error {
205205
return nil
206206
case []byte:
207207
n.Time, err = parseDateTime(string(v), time.UTC)
208-
n.Valid = (err == nil)
208+
n.Valid = err == nil
209209
return err
210210
case string:
211211
n.Time, err = parseDateTime(v, time.UTC)
212-
n.Valid = (err == nil)
212+
n.Valid = err == nil
213213
return err
214214
}
215215

0 commit comments

Comments
 (0)