scsi: libfc: free response frame from GPN_ID

Igor Druzhinin · martinkpetersen · commit ff6993bb79b9 · 2020-02-21T17:56:32.000-05:00
fc_disc_gpn_id_resp() should be the last function using it so free it here to avoid memory leak. Link: https://lore.kernel.org/r/1579013000-14570-2-git-send-email-igor.druzhinin@citrix.com Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c
@@ -628,6 +628,8 @@ static void fc_disc_gpn_id_resp(struct fc_seq *sp, struct fc_frame *fp,
 	}
 out:
 	kref_put(&rdata->kref, fc_rport_destroy);
+	if (!IS_ERR(fp))
+		fc_frame_free(fp);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -628,6 +628,8 @@ static void fc_disc_gpn_id_resp(struct fc_seq sp, struct fc_frame fp,`
`628`	`628`	`}`
`629`	`629`	`out:`
`630`	`630`	`kref_put(&rdata->kref, fc_rport_destroy);`
	`631`	`+ if (!IS_ERR(fp))`
	`632`	`+ fc_frame_free(fp);`
`631`	`633`	`}`
`632`	`634`
`633`	`635`	`/**`