Skip to content

Commit f0b9f54

Browse files
ISCAS-Vulabgregkh
authored andcommitted
clk: clk-atlas6: fix return value check in atlas6_clk_init()
[ Upstream commit 12b90b4 ] In case of error, the function clk_register() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Xu Wang <vulab@iscas.ac.cn> Link: https://lore.kernel.org/r/20200713032143.21362-1-vulab@iscas.ac.cn Acked-by: Barry Song <baohua@kernel.org> Fixes: 7bf21bc ("clk: sirf: re-arch to make the codes support both prima2 and atlas6") Signed-off-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 7fc9f68 commit f0b9f54

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/clk/sirf/clk-atlas6.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ static void __init atlas6_clk_init(struct device_node *np)
136136

137137
for (i = pll1; i < maxclk; i++) {
138138
atlas6_clks[i] = clk_register(NULL, atlas6_clk_hw_array[i]);
139-
BUG_ON(!atlas6_clks[i]);
139+
BUG_ON(IS_ERR(atlas6_clks[i]));
140140
}
141141
clk_register_clkdev(atlas6_clks[cpu], NULL, "cpu");
142142
clk_register_clkdev(atlas6_clks[io], NULL, "io");

0 commit comments

Comments
 (0)