Skip to content

Commit e39e773

Browse files
rddunlaptorvalds
authored andcommitted
fs/posix_acl.c: fix kernel-doc warnings
Fix kernel-doc warnings in fs/posix_acl.c. Also fix one typo (setgit -> setgid). fs/posix_acl.c:647: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode' fs/posix_acl.c:647: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode' fs/posix_acl.c:647: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode' Link: http://lkml.kernel.org/r/29b0dc46-1f28-a4e5-b1d0-ba2b65629779@infradead.org Fixes: 0739310 ("posix_acl: Clear SGID bit when setting file permissions") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Andreas Gruenbacher <agruenba@redhat.com> Reviewed-by: Jan Kara <jack@suse.cz> Cc: Jan Kara <jack@suse.cz> Cc: Andreas Gruenbacher <agruenba@redhat.com> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 63e8031 commit e39e773

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

fs/posix_acl.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -631,12 +631,15 @@ EXPORT_SYMBOL_GPL(posix_acl_create);
631631

632632
/**
633633
* posix_acl_update_mode - update mode in set_acl
634+
* @inode: target inode
635+
* @mode_p: mode (pointer) for update
636+
* @acl: acl pointer
634637
*
635638
* Update the file mode when setting an ACL: compute the new file permission
636639
* bits based on the ACL. In addition, if the ACL is equivalent to the new
637-
* file mode, set *acl to NULL to indicate that no ACL should be set.
640+
* file mode, set *@acl to NULL to indicate that no ACL should be set.
638641
*
639-
* As with chmod, clear the setgit bit if the caller is not in the owning group
642+
* As with chmod, clear the setgid bit if the caller is not in the owning group
640643
* or capable of CAP_FSETID (see inode_change_ok).
641644
*
642645
* Called from set_acl inode operations.

0 commit comments

Comments
 (0)