Input: psmouse - add a newline when printing 'proto' by sysfs

fenghusthu · gregkh · commit c4af8c25bd9b · 2020-08-26T10:31:01.000+02:00
[ Upstream commit 4aec14d ] When I cat parameter 'proto' by sysfs, it displays as follows. It's better to add a newline for easy reading. root@syzkaller:~# cat /sys/module/psmouse/parameters/proto autoroot@syzkaller:~# Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> Link: https://lore.kernel.org/r/20200720073846.120724-1-wangxiongfeng2@huawei.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
@@ -2044,7 +2044,7 @@ static int psmouse_get_maxproto(char *buffer, const struct kernel_param *kp)
 {
 	int type = *((unsigned int *)kp->arg);
 
-	return sprintf(buffer, "%s", psmouse_protocol_by_type(type)->name);
+	return sprintf(buffer, "%s\n", psmouse_protocol_by_type(type)->name);
 }
 
 static int __init psmouse_init(void)

Original file line number	Diff line number	Diff line change
`@@ -2044,7 +2044,7 @@ static int psmouse_get_maxproto(char buffer, const struct kernel_param kp)`
`2044`	`2044`	`{`
`2045`	`2045`	`int type = ((unsigned int )kp->arg);`
`2046`	`2046`
`2047`		`- return sprintf(buffer, "%s", psmouse_protocol_by_type(type)->name);`
	`2047`	`+ return sprintf(buffer, "%s\n", psmouse_protocol_by_type(type)->name);`
`2048`	`2048`	`}`
`2049`	`2049`
`2050`	`2050`	`static int __init psmouse_init(void)`