Skip to content

Commit a135b36

Browse files
Tom Rixgregkh
authored andcommitted
drm/bridge: sil_sii8620: initialize return of sii8620_readb
[ Upstream commit 02cd2d3 ] clang static analysis flags this error sil-sii8620.c:184:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] return ret; ^~~~~~~~~~ sii8620_readb calls sii8620_read_buf. sii8620_read_buf can return without setting its output pararmeter 'ret'. So initialize ret. Fixes: ce6e153 ("drm/bridge: add Silicon Image SiI8620 driver") Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20200712152453.27510-1-trix@redhat.com Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 84d2717 commit a135b36

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/bridge/sil-sii8620.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ static void sii8620_read_buf(struct sii8620 *ctx, u16 addr, u8 *buf, int len)
180180

181181
static u8 sii8620_readb(struct sii8620 *ctx, u16 addr)
182182
{
183-
u8 ret;
183+
u8 ret = 0;
184184

185185
sii8620_read_buf(ctx, addr, &ret, 1);
186186
return ret;

0 commit comments

Comments
 (0)