Skip to content

Commit 7a8abc9

Browse files
mmindgregkh
authored andcommitted
arm64: dts: rockchip: fix rk3399-puma gmac reset gpio
[ Upstream commit 8a44508 ] The puma gmac node currently uses opposite active-values for the gmac phy reset pin. The gpio-declaration uses active-high while the separate snps,reset-active-low property marks the pin as active low. While on the kernel side this works ok, other DT users may get confused - as seen with uboot right now. So bring this in line and make both properties match, similar to the other Rockchip board. Fixes: 2c66fc3 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM") Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com> Link: https://lore.kernel.org/r/20200603132836.362519-1-heiko@sntech.de Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent ecf6e25 commit 7a8abc9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@
156156
phy-mode = "rgmii";
157157
pinctrl-names = "default";
158158
pinctrl-0 = <&rgmii_pins>;
159-
snps,reset-gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_HIGH>;
159+
snps,reset-gpio = <&gpio3 RK_PC0 GPIO_ACTIVE_LOW>;
160160
snps,reset-active-low;
161161
snps,reset-delays-us = <0 10000 50000>;
162162
tx_delay = <0x10>;

0 commit comments

Comments
 (0)