Skip to content

Commit 4d627c8

Browse files
Faiz-AbbasUlf Hansson
authored andcommitted
mmc: sdhci_am654: Remove Inverted Write Protect flag
The MMC/SD controllers on am65x and j721e don't in fact detect the write protect line as inverted. No issues were detected because of this because the sdwp line is not connected on any of the evms. Fix this by removing the flag. Fixes: 1accbce ("mmc: sdhci_am654: Add Support for 4 bit IP on J721E") Cc: stable@vger.kernel.org Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> Link: https://lore.kernel.org/r/20200108143301.1929-2-faiz_abbas@ti.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent f667216 commit 4d627c8

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

drivers/mmc/host/sdhci_am654.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,7 @@ static struct sdhci_ops sdhci_am654_ops = {
253253

254254
static const struct sdhci_pltfm_data sdhci_am654_pdata = {
255255
.ops = &sdhci_am654_ops,
256-
.quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT |
257-
SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
256+
.quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
258257
.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
259258
};
260259

@@ -290,8 +289,7 @@ static struct sdhci_ops sdhci_j721e_8bit_ops = {
290289

291290
static const struct sdhci_pltfm_data sdhci_j721e_8bit_pdata = {
292291
.ops = &sdhci_j721e_8bit_ops,
293-
.quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT |
294-
SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
292+
.quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
295293
.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
296294
};
297295

@@ -314,8 +312,7 @@ static struct sdhci_ops sdhci_j721e_4bit_ops = {
314312

315313
static const struct sdhci_pltfm_data sdhci_j721e_4bit_pdata = {
316314
.ops = &sdhci_j721e_4bit_ops,
317-
.quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT |
318-
SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
315+
.quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
319316
.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
320317
};
321318

0 commit comments

Comments
 (0)