Skip to content

Commit 3fe4f18

Browse files
mmindgregkh
authored andcommitted
arm64: dts: rockchip: fix rk3368-lion gmac reset gpio
[ Upstream commit 2300e6d ] The lion gmac node currently uses opposite active-values for the gmac phy reset pin. The gpio-declaration uses active-high while the separate snps,reset-active-low property marks the pin as active low. While on the kernel side this works ok, other DT users may get confused - as seen with uboot right now. So bring this in line and make both properties match, similar to the other Rockchip board. Fixes: d99a02b ("arm64: dts: rockchip: add RK3368-uQ7 (Lion) SoM") Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com> Link: https://lore.kernel.org/r/20200607212909.920575-1-heiko@sntech.de Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 008560e commit 3fe4f18

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/arm64/boot/dts/rockchip/rk3368-lion.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@
159159
pinctrl-0 = <&rgmii_pins>;
160160
snps,reset-active-low;
161161
snps,reset-delays-us = <0 10000 50000>;
162-
snps,reset-gpio = <&gpio3 RK_PB3 GPIO_ACTIVE_HIGH>;
162+
snps,reset-gpio = <&gpio3 RK_PB3 GPIO_ACTIVE_LOW>;
163163
tx_delay = <0x10>;
164164
rx_delay = <0x10>;
165165
status = "okay";

0 commit comments

Comments
 (0)