Skip to content

Commit 3b17121

Browse files
stephan-ghgregkh
authored andcommitted
arm64: dts: qcom: msm8916: Replace invalid bias-pull-none property
[ Upstream commit 1b6a1a1 ] msm8916-pins.dtsi specifies "bias-pull-none" for most of the audio pin configurations. This was likely copied from the qcom kernel fork where the same property was used for these audio pins. However, "bias-pull-none" actually does not exist at all - not in mainline and not in downstream. I can only guess that the original intention was to configure "no pull", i.e. bias-disable. Change it to that instead. Fixes: 143bb9a ("arm64: dts: qcom: add audio pinctrls") Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Stephan Gerhold <stephan@gerhold.net> Link: https://lore.kernel.org/r/20200605185916.318494-2-stephan@gerhold.net Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 0a9c84c commit 3b17121

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

arch/arm64/boot/dts/qcom/msm8916-pins.dtsi

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@
516516
pins = "gpio63", "gpio64", "gpio65", "gpio66",
517517
"gpio67", "gpio68";
518518
drive-strength = <8>;
519-
bias-pull-none;
519+
bias-disable;
520520
};
521521
};
522522
cdc_pdm_lines_sus: pdm_lines_off {
@@ -545,7 +545,7 @@
545545
pins = "gpio113", "gpio114", "gpio115",
546546
"gpio116";
547547
drive-strength = <8>;
548-
bias-pull-none;
548+
bias-disable;
549549
};
550550
};
551551

@@ -573,7 +573,7 @@
573573
pinconf {
574574
pins = "gpio110";
575575
drive-strength = <8>;
576-
bias-pull-none;
576+
bias-disable;
577577
};
578578
};
579579

@@ -599,7 +599,7 @@
599599
pinconf {
600600
pins = "gpio116";
601601
drive-strength = <8>;
602-
bias-pull-none;
602+
bias-disable;
603603
};
604604
};
605605
ext_mclk_tlmm_lines_sus: mclk_lines_off {
@@ -627,7 +627,7 @@
627627
pins = "gpio112", "gpio117", "gpio118",
628628
"gpio119";
629629
drive-strength = <8>;
630-
bias-pull-none;
630+
bias-disable;
631631
};
632632
};
633633
ext_sec_tlmm_lines_sus: tlmm_lines_off {

0 commit comments

Comments
 (0)