nvme: Fix uninitialized-variable warning

keithbusch · keithbusch · commit 15755854d53b · 2020-02-20T01:40:57.000+09:00
gcc may detect a false positive on nvme using an unintialized variable
if setting features fails. Since this is not a fast path, explicitly
initialize this variable to suppress the warning.

Reported-by: Arnd Bergmann &lt;arnd@arndb.de&gt;
Reviewed-by: Christoph Hellwig &lt;hch@lst.de&gt;
Signed-off-by: Keith Busch &lt;kbusch@kernel.org&gt;
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
@@ -1165,8 +1165,8 @@ static int nvme_identify_ns(struct nvme_ctrl *ctrl,
 static int nvme_features(struct nvme_ctrl *dev, u8 op, unsigned int fid,
 		unsigned int dword11, void *buffer, size_t buflen, u32 *result)
 {
+	union nvme_result res = { 0 };
 	struct nvme_command c;
-	union nvme_result res;
 	int ret;
 
 	memset(&c, 0, sizeof(c));

Original file line number	Diff line number	Diff line change
`@@ -1165,8 +1165,8 @@ static int nvme_identify_ns(struct nvme_ctrl *ctrl,`
`1165`	`1165`	`static int nvme_features(struct nvme_ctrl *dev, u8 op, unsigned int fid,`
`1166`	`1166`	`unsigned int dword11, void buffer, size_t buflen, u32 result)`
`1167`	`1167`	`{`
	`1168`	`+ union nvme_result res = { 0 };`
`1168`	`1169`	`struct nvme_command c;`
`1169`		`- union nvme_result res;`
`1170`	`1170`	`int ret;`
`1171`	`1171`
`1172`	`1172`	`memset(&c, 0, sizeof(c));`