Delete the scheduled transition when the review entitiy is deleted or vice versa

[andybroomfield]

In order to uninstall, we need to delete all the the review date entities.
Except doing this will leave the scheduled transitions in place.
So we need a way to saftly remove the scheduled transitions and then remove the entitiy.
The review date entiity does store the transition id, so we can use that.
Also should apply the same vice versa.

[stephen-cox]

It's easy enough to add a hook to delete the associated scheduled transition entity when deleting a review date entity.

One concern is as scheduled transitions are separately managed, it is possible a user may use one created by the review date for some other purpose. This is probably quite unlikely, but it is something we should at least consider.

[andybroomfield]

Bumping this back up. This is code we currently have in a custom module that should properly go into this module.
Note: It's not currently possible to delete a review date from the admin view (we added that feature).

<?php

/**
 * @file
 * Primary module hooks for BHCC Workflows module.
 */

use Drupal\localgov_review_date\Entity\ReviewDateInterface;
use Drupal\scheduled_transitions\Entity\ScheduledTransitionInterface;

/**
 * Implements hook_ENTITY_TYPE_delete().
 */
function bhcc_workflows_review_date_review_date_delete(ReviewDateInterface $review_date) {

  // Find the scheduled transition.
  $scheduled_transition_id = $review_date->transition->target_id;
  $scheduled_transition_storage = \Drupal::entityTypeManager()->getStorage('scheduled_transition');
  $scheduled_transition = $scheduled_transition_storage->load($scheduled_transition_id);
  if ($scheduled_transition instanceof ScheduledTransitionInterface) {
    // Delete it.
    $scheduled_transition->delete();
  }
}