lkl: Fix -Wstringop-truncation

Rondom · Rondom · commit 7fa24af2dde1 · 2019-11-17T22:04:59.000+01:00
lib/virtio_net_tap.c: In function ‘lkl_netdev_tap_create’:
lib/virtio_net_tap.c:107:2: warning: ‘strncpy’ specified bound 16 equals
destination size [-Wstringop-truncation]

Signed-off-by: Andreas Gnau &lt;Rondom@Rondom.de&gt;
diff --git a/tools/lkl/lib/virtio_net_tap.c b/tools/lkl/lib/virtio_net_tap.c
@@ -104,7 +104,7 @@ struct lkl_netdev *lkl_netdev_tap_create(const char *ifname, int offload)
 #endif
 	};
 
-	strncpy(ifr.ifr_name, ifname, IFNAMSIZ);
+	snprintf(ifr.ifr_name, sizeof(ifr.ifr_name), "%s", ifname);
 
 	return lkl_netdev_tap_init(path, offload, &ifr);
 }

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ struct lkl_netdev lkl_netdev_tap_create(const char ifname, int offload)`
`104`	`104`	`#endif`
`105`	`105`	`};`
`106`	`106`
`107`		`- strncpy(ifr.ifr_name, ifname, IFNAMSIZ);`
	`107`	`+ snprintf(ifr.ifr_name, sizeof(ifr.ifr_name), "%s", ifname);`
`108`	`108`
`109`	`109`	`return lkl_netdev_tap_init(path, offload, &ifr);`
`110`	`110`	`}`