Fix functional tests (#160)

* Fix voiceBridge too short

* End meeting after each test, enforce guest policy on joinMeeting test

Author: samuelwei

tests/TestCase.php

@@ -72,7 +72,7 @@ protected function generateCreateParams()
             'moderatorPW' => $this->faker->password,
             'autoStartRecording' => $this->faker->boolean(50),
             'dialNumber' => $this->faker->phoneNumber,
-            'voiceBridge' => $this->faker->randomNumber(5),
+            'voiceBridge' => $this->faker->randomNumber(5, true),
             'webVoice' => $this->faker->word,
             'logoutURL' => $this->faker->url,
             'maxParticipants' => $this->faker->numberBetween(2, 100),

tests/functional/AbstractBigBlueButtonFunctionalTest.php

@@ -119,10 +119,12 @@ public function testCreateMeetingUrl(): void
      */
     public function testCreateMeeting()
     {
-        $params = $this->generateCreateParams();
-        $result = $this->bbb->createMeeting($this->getCreateMock($params));
+        $result = $this->createRealMeeting($this->bbb);
         $this->assertEquals('SUCCESS', $result->getReturnCode());
         $this->assertTrue($result->success());
+
+        // Cleanup
+        $this->bbb->endMeeting(new EndMeetingParameters($result->getMeetingId(), $result->getModeratorPassword()));
     }
 
     /**
@@ -138,6 +140,9 @@ public function testCreateMeetingWithDocumentUrl()
         $this->assertCount(1, $params->getPresentations());
         $this->assertEquals('SUCCESS', $result->getReturnCode());
         $this->assertTrue($result->success());
+
+        // Cleanup
+        $this->bbb->endMeeting(new EndMeetingParameters($result->getMeetingId(), $result->getModeratorPassword()));
     }
 
     /**
@@ -153,6 +158,9 @@ public function testCreateMeetingWithDocumentUrlAndFileName()
         $this->assertCount(1, $params->getPresentations());
         $this->assertEquals('SUCCESS', $result->getReturnCode());
         $this->assertTrue($result->success());
+
+        // Cleanup
+        $this->bbb->endMeeting(new EndMeetingParameters($result->getMeetingId(), $result->getModeratorPassword()));
     }
 
     /**
@@ -168,6 +176,9 @@ public function testCreateMeetingWithDocumentEmbedded()
         $this->assertCount(1, $params->getPresentations());
         $this->assertEquals('SUCCESS', $result->getReturnCode());
         $this->assertTrue($result->success());
+
+        // Cleanup
+        $this->bbb->endMeeting(new EndMeetingParameters($result->getMeetingId(), $result->getModeratorPassword()));
     }
 
     /**
@@ -184,6 +195,9 @@ public function testCreateMeetingWithMultiDocument()
         $this->assertCount(2, $params->getPresentations());
         $this->assertEquals('SUCCESS', $result->getReturnCode());
         $this->assertTrue($result->success());
+
+        // Cleanup
+        $this->bbb->endMeeting(new EndMeetingParameters($result->getMeetingId(), $result->getModeratorPassword()));
     }
 
     /* Join Meeting */
@@ -208,8 +222,9 @@ public function testCreateJoinMeetingUrl(): void
 
     public function testJoinMeeting()
     {
-        $params = $this->generateCreateParams();
-        $result = $this->bbb->createMeeting($this->getCreateMock($params));
+        $params = $this->getCreateMock($this->generateCreateParams());
+        $params->setGuestPolicy('ALWAYS_ACCEPT');
+        $result = $this->bbb->createMeeting($params);
         $this->assertEquals('SUCCESS', $result->getReturnCode(), 'Create meeting');
         $creationTime = $result->getCreationTime();
 
@@ -226,6 +241,9 @@ public function testJoinMeeting()
         $this->assertNotEmpty($joinMeeting->getSessionToken());
         $this->assertNotEmpty($joinMeeting->getGuestStatus());
         $this->assertNotEmpty($joinMeeting->getUrl());
+
+        // Cleanup
+        $this->bbb->endMeeting(new EndMeetingParameters($result->getMeetingId(), $result->getModeratorPassword()));
     }
 
     /* End Meeting */
@@ -283,8 +301,13 @@ public function testGetMeetingsUrl(): void
 
     public function testGetMeetings()
     {
+        $meeting = $this->createRealMeeting($this->bbb);
+
         $result = $this->bbb->getMeetings();
         $this->assertNotEmpty($result->getMeetings());
+
+        // Cleanup
+        $this->bbb->endMeeting(new EndMeetingParameters($meeting->getMeetingId(), $meeting->getModeratorPassword()));
     }
 
     /* Get meeting info */
@@ -295,6 +318,9 @@ public function testGetMeetingInfoUrl(): void
 
         $url = $this->bbb->getMeetingInfoUrl(new GetMeetingInfoParameters($meeting->getMeetingId()));
         $this->assertStringContainsString('='.rawurlencode($meeting->getMeetingId()), $url);
+
+        // Cleanup
+        $this->bbb->endMeeting(new EndMeetingParameters($meeting->getMeetingId(), $meeting->getModeratorPassword()));
     }
 
     public function testGetMeetingInfo()
@@ -304,6 +330,9 @@ public function testGetMeetingInfo()
         $result = $this->bbb->getMeetingInfo(new GetMeetingInfoParameters($meeting->getMeetingId(), $meeting->getModeratorPassword()));
         $this->assertEquals('SUCCESS', $result->getReturnCode());
         $this->assertTrue($result->success());
+
+        // Cleanup
+        $this->bbb->endMeeting(new EndMeetingParameters($meeting->getMeetingId(), $meeting->getModeratorPassword()));
     }
 
     public function testGetRecordingsUrl(): void