Merge pull request #154 from littleredbutton/fix-code-style

Fix code style

Author: samuelwei

.php-cs-fixer.php

@@ -18,6 +18,8 @@
         'yoda_style' => false,
         'single_line_throw' => false,
         'increment_style' => false,
+        'modernize_strpos' => false,
+        'get_class_to_class_keyword' => false,
     ])
     ->setRiskyAllowed(true)
     ->setFinder($finder);

src/BigBlueButton.php

@@ -59,7 +59,6 @@
 use BigBlueButton\Responses\PutRecordingTextTrackResponse;
 use BigBlueButton\Responses\UpdateRecordingsResponse;
 use BigBlueButton\Util\UrlBuilder;
-use SimpleXMLElement;
 
 /**
  * Class BigBlueButton.
@@ -108,7 +107,7 @@ class BigBlueButton
      *
      * @throws ConfigException
      */
-    public function __construct(?string $baseUrl = null, ?string $secret = null, ?TransportInterface $transport = null)
+    public function __construct(string $baseUrl = null, string $secret = null, TransportInterface $transport = null)
     {
         // Keeping backward compatibility with older deployed versions
         $this->securitySecret = $secret ?: getenv('BBB_SECURITY_SALT') ?: getenv('BBB_SECRET');
@@ -478,10 +477,10 @@ public function setJSessionId(string $jSessionId): void
      * @throws ParsingException
      * @throws RuntimeException
      */
-    private function processXmlResponse(string $url, string $payload = '', string $contentType = 'application/xml'): SimpleXMLElement
+    private function processXmlResponse(string $url, string $payload = '', string $contentType = 'application/xml'): \SimpleXMLElement
     {
         try {
-            return new SimpleXMLElement($this->requestUrl($url, $payload, $contentType));
+            return new \SimpleXMLElement($this->requestUrl($url, $payload, $contentType));
         } catch (NetworkException|RuntimeException $e) {
             throw $e;
         } catch (\Throwable $e) {

src/Exceptions/BaseException.php

@@ -21,11 +21,9 @@
 
 namespace BigBlueButton\Exceptions;
 
-use Exception;
-
 /**
  * @abstract since 4.0.
  */
-class BaseException extends Exception
+class BaseException extends \Exception
 {
 }

src/Http/Transport/Bridge/PsrHttpClient/PsrHttpClientTransport.php

@@ -104,9 +104,6 @@ public function __construct(
         $this->defaultHeaders = $defaultHeaders;
     }
 
-    /**
-     * {@inheritDoc}
-     */
     public function request(TransportRequest $request): TransportResponse
     {
         if ('' !== $payload = $request->getPayload()) {

src/Http/Transport/Bridge/SymfonyHttpClient/SymfonyHttpClientTransport.php

@@ -101,9 +101,6 @@ public static function create(array $defaultHeaders = [], array $defaultOptions
         // @codeCoverageIgnoreEnd
     }
 
-    /**
-     * {@inheritDoc}
-     */
     public function request(TransportRequest $request): TransportResponse
     {
         $headers = $this->defaultHeaders;

src/Http/Transport/CurlTransport.php

@@ -84,9 +84,6 @@ public static function createWithDefaultOptions(array $additionalCurlOptions = [
         // @codeCoverageIgnoreEnd
     }
 
-    /**
-     * {@inheritDoc}
-     */
     public function request(TransportRequest $request): TransportResponse
     {
         // @codeCoverageIgnoreStart

src/Parameters/BaseParameters.php

@@ -45,9 +45,6 @@ public function __call(string $name, array $arguments)
         return null;
     }
 
-    /**
-     * @return mixed
-     */
     protected function getter(string $name)
     {
         if (property_exists($this, $name)) {

src/Parameters/CreateMeetingParameters.php

@@ -476,7 +476,7 @@ public function setGuestPolicyAlwaysAccept(): self
         return $this;
     }
 
-    public function addPresentation(string $nameOrUrl, ?string $content = null, ?string $filename = null): self
+    public function addPresentation(string $nameOrUrl, string $content = null, string $filename = null): self
     {
         if (!$filename) {
             $this->presentations[$nameOrUrl] = !$content ?: base64_encode($content);
@@ -492,9 +492,6 @@ public function getPresentations(): array
         return $this->presentations;
     }
 
-    /**
-     * @return mixed
-     */
     public function getPresentationsAsXML()
     {
         $result = '';

src/Parameters/InsertDocumentParameters.php

@@ -42,7 +42,7 @@ public function __construct(string $meetingID)
         $this->meetingID = $meetingID;
     }
 
-    public function addPresentation(string $url, string $filename, ?bool $downloadable = null, ?bool $removable = null): self
+    public function addPresentation(string $url, string $filename, bool $downloadable = null, bool $removable = null): self
     {
         $this->presentations[$url] = [
             'filename' => $filename,
@@ -60,9 +60,6 @@ public function removePresentation(string $url): self
         return $this;
     }
 
-    /**
-     * @return mixed
-     */
     public function getPresentationsAsXML()
     {
         $result = '';

src/Parameters/PutRecordingTextTrackParameters.php

@@ -62,15 +62,10 @@ class PutRecordingTextTrackParameters extends BaseParameters
      */
     protected $contentType;
 
-    /**
-     * @var mixed
-     */
     protected $file;
 
     /**
      * GetRecordingTextTracksParameters constructor.
-     *
-     * @param $recordID
      */
     public function __construct(string $recordID, string $kind, string $lang, string $label)
     {