Skip to content

Commit 27253fc

Browse files
authored
Merge pull request #153 from littleredbutton/remove-configToken
Remove config token
2 parents 11bf11b + 190bbbc commit 27253fc

2 files changed

Lines changed: 27 additions & 5 deletions

File tree

src/Parameters/JoinMeetingParameters.php

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@
3434
* @method $this setUserID(string $userID)
3535
* @method string getWebVoiceConf()
3636
* @method $this setWebVoiceConf(string $webVoiceConf)
37-
* @method string getConfigToken()
38-
* @method $this setConfigToken(string $configToken)
3937
* @method string getDefaultLayout()
4038
* @method $this setDefaultLayout(string $defaultLayout)
4139
* @method string getAvatarURL()
@@ -137,4 +135,22 @@ public function __construct(string $meetingID, string $fullName, string $passwor
137135
$this->fullName = $fullName;
138136
$this->password = $password;
139137
}
138+
139+
/**
140+
* @deprecated old flash client parameter, not used anymore
141+
*/
142+
public function getConfigToken(): ?string
143+
{
144+
return $this->configToken;
145+
}
146+
147+
/**
148+
* @deprecated old flash client parameter, not used anymore
149+
*/
150+
public function setConfigToken(string $configToken): self
151+
{
152+
$this->configToken = $configToken;
153+
154+
return $this;
155+
}
140156
}

tests/TestCase.php

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ protected function generateJoinMeetingParams()
237237
'userID' => $this->faker->numberBetween(1, 1000),
238238
'webVoiceConf' => $this->faker->word,
239239
'createTime' => $this->faker->unixTime,
240+
'configToken' => $this->faker->word,
240241
'userdata-countrycode' => $this->faker->countryCode,
241242
'userdata-email' => $this->faker->email,
242243
'userdata-commercial' => false,
@@ -252,9 +253,14 @@ protected function getJoinMeetingMock($params)
252253
{
253254
$joinMeetingParams = new JoinMeetingParameters($params['meetingID'], $params['fullName'], $params['password']);
254255

255-
return $joinMeetingParams->setUserID($params['userID'])->setWebVoiceConf($params['webVoiceConf'])
256-
->setCreateTime($params['createTime'])->addUserData('countrycode', $params['userdata-countrycode'])
257-
->addUserData('email', $params['userdata-email'])->addUserData('commercial', $params['userdata-commercial']);
256+
return $joinMeetingParams
257+
->setUserID($params['userID'])
258+
->setWebVoiceConf($params['webVoiceConf'])
259+
->setCreateTime($params['createTime'])
260+
->setConfigToken($params['configToken'])
261+
->addUserData('countrycode', $params['userdata-countrycode'])
262+
->addUserData('email', $params['userdata-email'])
263+
->addUserData('commercial', $params['userdata-commercial']);
258264
}
259265

260266
/**

0 commit comments

Comments
 (0)