nemo-action.c: Allow absolute path pattern matching for File and

Location filters.

Rewrite File and Location descriptions in the sample action.

Author: mtwebster

files/usr/share/nemo/actions/sample.nemo_action

@@ -124,52 +124,36 @@ Extensions=any;
 
 #UriScheme=file
 
-# Locations - semicolor-separated array of directory names and globs to check against the
-# selection's parent location.
+# Locations and Files - semicolon-separated arrays of globs, filenames and paths to be tested
+# against the current location or selection, respectively.
 #
-# If Locations is defined, an action will *only* be valid under one of the following conditions:
-#     - The current location's filename (foo.bar, no path) is captured by *at least one*
-#       of any defined glob patterns.
-#     - The current location's filename exactly matches *at least one* defined filename.
+# - Globs and paths can be relative or absolute.
+# - ~ will be expanded at runtime to the user's home directory.
+# - Absolute paths will be tested against the file/location's full path. Otherwise it is tested
+#   against the filename only.
+# - A glob with a leading * will be matched against the full path, whether it contains additional
+#   path parts or is just a partial filename.
+# - If a condition is prefixed with a ! it will be considered an opposing condition (If the file
+#   passes this test, action is forbidden).
+# - Allowed patterns are considered before forbidden ones. This allows behaviors such as:
 #
-# If an entry is prefixed with '!', the above conditions are reversed, and an action is
-# considered *invalid* if any matches are made.
+#     # Allow any dot-file except .config
+#     Locations=.*;!.config
 #
-# NOTE: Allowed patterns are considered before forbidden ones. This means that a location
-#       would be invalidated by not matching any allowed patterns before being invalidated
-#       by matching forbidden ones.
-#
-# Example desired condition: Match any dot-file locations except '.config':
-#
-# Locations=.*;!.config
+
+# Locations - semicolon-separated array of globs to check against the currently location.
 #
-# Action would be visible when right-clicking the file '.foo/bar', but not '.config/bar'
+# The current location must match at least one 'allowed' pattern, path or name for the action
+# to be considered valid.
 #
 # Optional
 
 #Locations=.*;!.config;
 
-# Files - semicolor-separated array of file names and globs to check against the currently
-# selected file list.
-#
-# If Files is defined, an action will *only* be valid under the following conditions:
-#     - All selected filenames (foo.bar, no path) are captured by *at least one* of any
-#       defined glob patterns.
-#     - All file absolute paths exactly match *at least one* of any defined absolute paths.
-#     - All filenames exactly match *at least one* of the defined filenames.
-#
-# If an entry is prefixed with '!', the above conditions are reversed, and an action is
-# considered *invalid* if any matches are made.
-#
-# NOTE: Allowed patterns are considered before forbidden ones. This means that a filename
-#       would be invalidated by not matching any allowed patterns before being invalidated
-#       by matching forbidden ones.
-#
-# Example desired condition: Match .bash* but not '.bashrc':
-#
-# Files=.bash*;!.bashrc;
+# Files - semicolon-separated array of globs to check against the currently selected files.
 #
-# Action would be visible when right-clicking the file '.bash_history', but not '.bashrc'
+# All files in the selection must match at least one 'allowed' pattern, path or name for
+# the action to be considered valid.
 #
 # Optional
 

libnemo-private/nemo-action.c

@@ -133,6 +133,11 @@ typedef struct {
     guint handler_id;
 } GSettingsCondition;
 
+typedef struct {
+    GPatternSpec *pattern;
+    gboolean      absolute;
+} MatchPattern;
+
 static void
 dbus_condition_free (gpointer data)
 {
@@ -157,6 +162,29 @@ gsettings_condition_free (gpointer data)
     g_free (cond);
 }
 
+static MatchPattern *
+new_match_pattern (const gchar *pattern)
+{
+    MatchPattern *mp = g_new0 (MatchPattern, 1);
+
+    mp->pattern = g_pattern_spec_new (pattern);
+
+    // A pattern with a leading * can be matched against a full path, whether it has
+    // any other path elements or not (*/foo/bar/* or *.foo)
+    mp->absolute = g_str_has_prefix (pattern, "/") || g_str_has_prefix (pattern, "*");
+
+    return mp;
+}
+
+static void
+free_match_pattern (gpointer data)
+{
+    MatchPattern *mp = (MatchPattern *) data;
+
+    g_pattern_spec_free (mp->pattern);
+    g_free (mp);
+}
+
 static void
 nemo_action_init (NemoAction *action)
 {
@@ -580,23 +608,29 @@ populate_patterns_and_filenames (NemoAction   *action,
     gint i;
 
     for (i = 0; i < g_strv_length (array); i++) {
-        const gchar *str = array[i];
+        GString *str = g_string_new (array[i]);
+
+        g_string_replace (str, "~", g_get_home_dir (), 1);
+
+        g_printerr ("str: '%s'\n", str->str);
 
-        if (g_strstr_len (str, -1, "?") || g_strstr_len (str, -1, "*")) {
-            if (g_str_has_prefix (array[i], "!")) {
-                *forbidden_patterns = g_list_prepend (*forbidden_patterns, g_pattern_spec_new (array[i] + 1));
+        if (g_strstr_len (str->str, -1, "?") || g_strstr_len (str->str, -1, "*")) {
+            if (g_str_has_prefix (str->str, "!")) {
+                *forbidden_patterns = g_list_prepend (*forbidden_patterns, new_match_pattern (str->str + 1));
             } else {
-                *allowed_patterns = g_list_prepend (*allowed_patterns, g_pattern_spec_new (array[i]));
+                *allowed_patterns = g_list_prepend (*allowed_patterns, new_match_pattern (str->str));
             }
-
-            continue;
         }
-
-        if (g_str_has_prefix (array[i], "!")) {
-            *forbidden_filenames = g_list_prepend (*forbidden_filenames, g_strdup (array[i] + 1));
-        } else {
-            *allowed_filenames = g_list_prepend (*allowed_filenames, g_strdup (array[i]));
+        else
+        {
+            if (g_str_has_prefix (str->str, "!")) {
+                *forbidden_filenames = g_list_prepend (*forbidden_filenames, g_strdup (str->str + 1));
+            } else {
+                *allowed_filenames = g_list_prepend (*allowed_filenames, g_strdup (str->str));
+            }
         }
+
+        g_string_free (str, TRUE);
     }
 
     *allowed_patterns = g_list_reverse (*allowed_patterns);
@@ -991,10 +1025,10 @@ nemo_action_finalize (GObject *object)
     g_list_free_full (priv->dbus, (GDestroyNotify) dbus_condition_free);
     g_list_free_full (priv->gsettings, (GDestroyNotify) gsettings_condition_free);
 
-    g_list_free_full (priv->allowed_location_patterns, (GDestroyNotify) g_pattern_spec_free);
-    g_list_free_full (priv->forbidden_location_patterns, (GDestroyNotify) g_pattern_spec_free);
-    g_list_free_full (priv->allowed_patterns, (GDestroyNotify) g_pattern_spec_free);
-    g_list_free_full (priv->forbidden_patterns, (GDestroyNotify) g_pattern_spec_free);
+    g_list_free_full (priv->allowed_location_patterns, (GDestroyNotify) free_match_pattern);
+    g_list_free_full (priv->forbidden_location_patterns, (GDestroyNotify) free_match_pattern);
+    g_list_free_full (priv->allowed_patterns, (GDestroyNotify) free_match_pattern);
+    g_list_free_full (priv->forbidden_patterns, (GDestroyNotify) free_match_pattern);
     g_list_free_full (priv->allowed_location_filenames, (GDestroyNotify) g_free);
     g_list_free_full (priv->forbidden_location_filenames, (GDestroyNotify) g_free);
     g_list_free_full (priv->allowed_filenames, (GDestroyNotify) g_free);
@@ -1686,7 +1720,10 @@ check_is_allowed (NemoAction *action,
             allowed_allowed = FALSE;
 
             for (ll = allowed_patterns; ll != NULL; ll = ll->next) {
-                if (g_pattern_spec_match ((GPatternSpec *) ll->data, strlen (name), name, NULL)) {
+                MatchPattern *mp = (MatchPattern *) ll->data;
+                const gchar *test_str = mp->absolute ? path : name;
+
+                if (g_pattern_spec_match (mp->pattern, strlen (test_str), test_str, NULL)) {
                     allowed_allowed = TRUE;
                     break;
                 }
@@ -1711,7 +1748,10 @@ check_is_allowed (NemoAction *action,
             // (forbidden_allowed = TRUE;)
 
             for (ll = forbidden_patterns; ll != NULL; ll = ll->next) {
-                if (g_pattern_spec_match ((GPatternSpec *) ll->data, strlen (name), name, NULL)) {
+                MatchPattern *mp = (MatchPattern *) ll->data;
+                const gchar *test_str = mp->absolute ? path : name;
+
+                if (g_pattern_spec_match (mp->pattern, strlen (test_str), test_str, NULL)) {
                     forbidden_allowed = FALSE;
                     break;
                 }