Skip to content

Commit e03ef7c

Browse files
committed
modules/coreboot: split dasharo base revisions
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
1 parent 960d1db commit e03ef7c

9 files changed

Lines changed: 49 additions & 21 deletions

File tree

boards/UNTESTED_msi_z690a_ddr4/UNTESTED_msi_z690a_ddr4.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# MSI PRO Z690-A DDR4 board configuration
22

33
export CONFIG_COREBOOT=y
4-
export CONFIG_COREBOOT_VERSION=dasharo_msi
4+
export CONFIG_COREBOOT_VERSION=dasharo_msi_z690
55
export CONFIG_LINUX_VERSION=6.1.8
66

77
CONFIG_COREBOOT_CONFIG=config/coreboot-msi_z690a_ddr4.config

boards/UNTESTED_msi_z690a_ddr5/UNTESTED_msi_z690a_ddr5.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# MSI PRO Z690-A (DDR5) board configuration
22

33
export CONFIG_COREBOOT=y
4-
export CONFIG_COREBOOT_VERSION=dasharo_msi
4+
export CONFIG_COREBOOT_VERSION=dasharo_msi_z690
55
export CONFIG_LINUX_VERSION=6.1.8
66

77
CONFIG_COREBOOT_CONFIG=config/coreboot-msi_z690a_ddr5.config

boards/UNTESTED_msi_z790p_ddr4/UNTESTED_msi_z790p_ddr4.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# MSI PRO Z790-P DDR4 board configuration
22

33
export CONFIG_COREBOOT=y
4-
export CONFIG_COREBOOT_VERSION=dasharo_msi
4+
export CONFIG_COREBOOT_VERSION=dasharo_msi_z790
55
export CONFIG_LINUX_VERSION=6.1.8
66

77
CONFIG_COREBOOT_CONFIG=config/coreboot-msi_z790p_ddr4.config

boards/UNTESTED_nitropad-ns50/UNTESTED_nitropad-ns50.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# Dissassembly and Recovery: https://docs.dasharo.com/unified/novacustom/recovery/#ns5x7x-12th-gen
66

77
export CONFIG_COREBOOT=y
8-
export CONFIG_COREBOOT_VERSION=dasharo
8+
export CONFIG_COREBOOT_VERSION=dasharo_nv4x
99
export CONFIG_LINUX_VERSION=6.1.8
1010

1111
CONFIG_COREBOOT_CONFIG=config/coreboot-nitropad-ns50.config

boards/msi_z790p_ddr5/msi_z790p_ddr5.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# MSI PRO Z790-P (DDR5) board configuration
22

33
export CONFIG_COREBOOT=y
4-
export CONFIG_COREBOOT_VERSION=dasharo_msi
4+
export CONFIG_COREBOOT_VERSION=dasharo_msi_z790
55
export CONFIG_LINUX_VERSION=6.1.8
66

77
CONFIG_COREBOOT_CONFIG=config/coreboot-msi_z790p_ddr5.config

boards/novacustom-nv4x_adl/novacustom-nv4x_adl.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# Dissassembly and Recovery: https://docs.dasharo.com/unified/novacustom/recovery/#12th-gen
66

77
export CONFIG_COREBOOT=y
8-
export CONFIG_COREBOOT_VERSION=dasharo
8+
export CONFIG_COREBOOT_VERSION=dasharo_nv4x
99
export CONFIG_LINUX_VERSION=6.1.8
1010

1111
CONFIG_COREBOOT_CONFIG=config/coreboot-novacustom-nv4x_adl.config

boards/novacustom-v540tu/novacustom-v540tu.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# ME/CSME for s0ix to work (unsupported by QubesOS when writing those lines) or use Hibernate (Not supported by QubesOS either)
1515

1616
export CONFIG_COREBOOT=y
17-
export CONFIG_COREBOOT_VERSION=dasharo
17+
export CONFIG_COREBOOT_VERSION=dasharo_v56
1818
export CONFIG_DASHARO_EC=y
1919
export CONFIG_LINUX_VERSION=6.1.8
2020

boards/novacustom-v560tu/novacustom-v560tu.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# ME/CSME for s0ix to work (unsupported by QubesOS when writing those lines) or use Hibernate (Not supported by QubesOS either)
1515

1616
export CONFIG_COREBOOT=y
17-
export CONFIG_COREBOOT_VERSION=dasharo
17+
export CONFIG_COREBOOT_VERSION=dasharo_v56
1818
export CONFIG_DASHARO_EC=y
1919
export CONFIG_LINUX_VERSION=6.1.8
2020

modules/coreboot

Lines changed: 41 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ coreboot-24.02.01_hash := e56f5c0c9008bfdec1c4be6409ac093680140f9441efd3d5e47bde
7777
coreboot-blobs-24.02.01_hash := 8d03b82cd2b2593473d4cd511c7bef7fdd43839237f6c37a8383161660c14427
7878
$(eval $(call coreboot_module,24.02.01,))
7979

80+
coreboot-24.12_hash := dd211bdd914509aea7526348db13cf8b809acd0e2214da6c6b008975f04587ed
81+
coreboot-blobs-24.12_hash := e75a788fa4910d48c42e9997ff55f27aaa06dc2999bab9b60483172ea587e7c0
82+
$(eval $(call coreboot_module,24.12,))
83+
84+
coreboot-25.03_hash := 9182f84c0bf869cb97601594edd50f5891e97b9dc34c0e158bce2cf9ed51175a
85+
coreboot-blobs-25.03_hash := 03e8f565f73b932f942f08f0058d37080e1d2b0ce866596c25e607d14d1e95f0
86+
$(eval $(call coreboot_module,25.03,))
87+
8088
# coreboot git forks
8189

8290
# talos_2 could use the 4.20.1 toolchain, but it's the only ppc64 fork, so
@@ -91,18 +99,36 @@ coreboot-purism_repo := https://source.puri.sm/firmware/coreboot.git
9199
coreboot-purism_commit_hash := bea9947a1279be7d4a72b38a601d0288d10d1cb8
92100
$(eval $(call coreboot_module,purism,24.02.01))
93101

94-
# NovaCustom NV4xPZ, NS5xPU, V560TU boards are based on Dasharo
95-
# coreboot fork, based on upstream coreboot version 24.02
96-
coreboot-dasharo_repo := https://github.com/dasharo/coreboot
97-
coreboot-dasharo_commit_hash := 6de027d1f0a62753182237ce3d793e5ba0395139
98-
$(eval $(call coreboot_module,dasharo,24.02.01))
99-
#coreboot-dasharo_patch_version := unreleased
100-
101-
# MSI boards are based on Dasharo, this commit hash should be pinned to
102-
# the most recent MSI release.
103-
coreboot-dasharo_msi_repo := https://github.com/dasharo/coreboot
104-
coreboot-dasharo_msi_commit_hash := a5a05f133471c0463609631b599cdd88a623561f # This is `msi_ms7e06_v0.9.4` tag, effectively same as `msi_ms7d25_v1.1.6`.
105-
$(eval $(call coreboot_module,dasharo_msi,24.02.01))
102+
# Dasharo forks - based on various coreboot upstream releases
103+
# IMPORTANT: Dasharo forks CANNOT share toolchains with upstream coreboot releases
104+
# or with each other. Dasharo uses custom FSP packages (3rdparty/dasharo-blobs/)
105+
# with different/missing headers vs upstream (e.g. MemInfoHob.h, FirmwareVersionInfoHob.h).
106+
# Each Dasharo fork therefore builds its own crossgcc toolchain (empty second arg).
107+
108+
# NovaCustom V560TU/V540TU (Meteor Lake)
109+
# Tag: novacustom_v56x_mtl_igpu_v1.0.1 (SHA: 6de027d1)
110+
coreboot-dasharo_v56_repo := https://github.com/dasharo/coreboot
111+
coreboot-dasharo_v56_commit_hash := 6de027d1f0a62753182237ce3d793e5ba0395139
112+
$(eval $(call coreboot_module,dasharo_v56,))
113+
coreboot-dasharo_v56_patch_version := unreleased
114+
115+
# NovaCustom NV4x ADL / NitroPad NS50
116+
# Tag: novacustom_nv4x_adl_v1.8.0 (SHA: 281a7fec)
117+
coreboot-dasharo_nv4x_repo := https://github.com/dasharo/coreboot
118+
coreboot-dasharo_nv4x_commit_hash := 281a7fec1a1e7aed781b12a096c2fc0f87dc51b5
119+
$(eval $(call coreboot_module,dasharo_nv4x,))
120+
121+
# MSI Z790 boards
122+
# Tag: msi_ms7e06_v0.9.4 (SHA: a5a05f13)
123+
coreboot-dasharo_msi_z790_repo := https://github.com/dasharo/coreboot
124+
coreboot-dasharo_msi_z790_commit_hash := a5a05f133471c0463609631b599cdd88a623561f
125+
$(eval $(call coreboot_module,dasharo_msi_z790,))
126+
127+
# MSI Z690 boards
128+
# Tag: msi_ms7d25_v1.1.6 (SHA: be7d58da)
129+
coreboot-dasharo_msi_z690_repo := https://github.com/dasharo/coreboot
130+
coreboot-dasharo_msi_z690_commit_hash := be7d58dac9365d8981dbb1f5c6bbbcce35df8636
131+
$(eval $(call coreboot_module,dasharo_msi_z690,))
106132

107133
# T480 is based on coreboot ~25.09 release
108134
# coreboot 25.09 doesn't include Thunderbolt support and support of the lower USB-C port which is still under review at https://review.coreboot.org/c/coreboot/+/75286 and https://review.coreboot.org/c/coreboot/+/88490
@@ -128,6 +154,7 @@ coreboot_dir := $($(coreboot_module)_dir)
128154
coreboot_base_dir := $($(coreboot_module)_base_dir)
129155

130156
$(coreboot_module)_depends += $(if $(CONFIG_PURISM_BLOBS), purism-blobs)
157+
$(coreboot_module)_depends += $(if $(CONFIG_DASHARO_EC), dasharo-ec)
131158

132159
# coreboot builds are specialized on a per-target basis.
133160
# The builds are done in a per-target subdirectory
@@ -172,6 +199,7 @@ $(coreboot_module)_configure := \
172199
sed -i '/^CONFIG_MAINBOARD_SMBIOS_MANUFACTURER/d' $(build)/$(coreboot_dir)/.config; \
173200
echo 'CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="$(CONFIG_COREBOOT_SMBIOS_MANUFACTURER)"' >> $(build)/$(coreboot_dir)/.config; \
174201
fi; \
202+
sed -i 's|@COREBOOT_BUILD_DIR@|$(build)/$(coreboot_dir)|g' "$(build)/$(coreboot_dir)/.config"; \
175203
$(MAKE) olddefconfig \
176204
-C "$(build)/$(coreboot_base_dir)" \
177205
obj="$(build)/$(coreboot_dir)" \
@@ -290,7 +318,7 @@ coreboot.save_in_defconfig_format_in_place:
290318
olddefconfig && \
291319
$(MAKE) \
292320
-C "$(build)/$(coreboot_base_dir)" \
293-
DOTCONFIG="$(build)/$(coreboot_dir)/.config" \
321+
DOTCONFIG="$(build)/$(coreboot_dir)/.config" \
294322
savedefconfig && \
295323
mv "$(build)/$(coreboot_base_dir)/defconfig" "$(pwd)/$(CONFIG_COREBOOT_CONFIG)"
296324

0 commit comments

Comments
 (0)