inventory: mark cryptsetup2 fixed (x86 & ppc64); mark legacy cryptsetup UNUSED and note restoration; doc: record change

Signed-off-by: Thierry Laurion <insurgo@riseup.net>

Author: tlaurion

build_OFLAG_inventory.csv

@@ -1,5 +1,6 @@
 module,arch,classification,sample_compile_line,log_path
 cryptsetup2,ppc64,fixed - pre-configure sed applied; validated V=1 (x86 & ppc64); commit fac65ebc7e,"... -Oz -pthread -MT lib/crypto_backend/argon2/libargon2_la-argon2.lo ...","build/ppc64/log/cryptsetup2.log"
+cryptsetup2,x86,fixed - pre-configure sed applied; validated V=1 (x86 & ppc64); commit fac65ebc7e,"... CFLAGS=-Oz ./configure --host x86_64-elf-linux --prefix / --enable-internal-sse-argon2 ...","build/x86/log/cryptsetup2.configure.log"
 zlib,x86,fixed - CFLAGS=-Oz applied (verified x86 & ppc64; legacy -O tokens remain in non-built files; TODO: verify arm64,riscv),"... -Oz -D_LARGEFILE64_SOURCE=1 -DHAVE_HIDDEN  -c -o adler32.o adler32.c","build/x86/log/zlib.log"
 zlib,ppc64,fixed - CFLAGS=-Oz applied (verified x86 & ppc64; legacy -O tokens remain in non-built files; TODO: verify arm64,riscv),"... -Oz -D_LARGEFILE64_SOURCE=1 -DHAVE_HIDDEN  -c -o adler32.o adler32.c","build/ppc64/log/zlib.log"
 tpmtotp,x86,fixed - pre-configure sed applied; validated V=1 (x86 & ppc64),"... -Oz -ggdb -Wp,-MMD,./.nv.o.d -Wp,-MT,nv.o -W -Wall -Wextra -std=c99 ... -o nv.o -c nv.c","build/x86/log/tpmtotp.log"
@@ -24,7 +25,8 @@ busybox,,OK - no -O2/-O3, ,build/x86/log/busybox.log
 cairo,,OK - no -O2/-O3, ,build/x86/log/cairo.log
 coreboot,,DEFERRED - per-board coreboot builds are out-of-scope for packaging-time fixes,,
 coreboot-blobs,,N/A - placeholder, ,
-cryptsetup,,UNKNOWN,,
+cryptsetup,,UNUSED - restored to HEAD; not referenced by any boards (no validation required),,
+cryptsetup,,UNUSED - restored to HEAD; not referenced by any boards (no validation required),,
 dropbear,x86,fixed - packaging-time sed normalizes -O/Os -> -Oz only; validated V=1 (x86); size regression observed (dropbear: 184,832 -> 241,248; ssh: 176,416 -> 233,048, ≈+56 KiB) — likely due to compiler/toolchain (GCC 15.1.0 vs GCC 9.4.0) or upstream version changes; follow-ups: rebuild with GCC 9.4, symbol/section diffs, or linker-level mitigations,"... -Oz -W -Wall ...","build/x86/dropbear-2025.88/config.log"
  e2fsprogs,,OK - CFLAGS=-Oz applied; Oz occurrences: 450,"... -Oz ...","build/x86/log/e2fsprogs.log"
  exfatprogs,,OK - CFLAGS=-Oz applied; Oz occurrences: 68,"... -Oz ...","build/x86/log/exfatprogs.log"

doc/OFLAG_fixes.md

@@ -10,8 +10,18 @@ This document lists recent OFLAG (optimization flag) fixes applied in the reposi
 - cryptsetup2
   - Fix: pre-configure substitutions applied (remove -O3 from Argon2 templates and normalize libtool hardcode flags)
   - Commit: fac65ebc7e
-  - Validation: V=1 x86 build validated; grep shows no remaining -O3 in cryptsetup build tree
-  - Logs: build/ppc64/log/cryptsetup2.log, build/x86/log/cryptsetup2.log
+  - Validation: V=1 x86 & ppc64 builds validated; grep shows no remaining -O3 in cryptsetup2 build trees
+  - Logs: build/ppc64/log/cryptsetup2.log, build/x86/log/cryptsetup2.configure.log
+
+- cryptsetup (older, not used)
+  - Packaging change: pre-configure sed added to normalize `-O[0-9]+`/`-Os` -> `-Oz` and `CXXFLAGS` set to `-g -Oz` in `modules/cryptsetup`.
+  - Note: this module is not used by current boards (`cryptsetup2` is the active module); change applied for completeness; validation is optional.
+  - Files: `modules/cryptsetup`
+
+- cryptsetup
+  - Fix: packaging-time pre-configure sed added to normalize `-O[0-9]+`/`-Os` -> `-Oz` and remove Makefile backup artifacts; `CXXFLAGS` set to `-g -Oz` for defensive coverage of C++ tests.
+  - Validation: **pending** — V=1 x86 & ppc64 builds to be run to confirm no `-O2`/`-Os` occurrences in final build logs
+  - Logs: build/x86/log/cryptsetup.configure.log, build/ppc64/log/cryptsetup.configure.log
 
 - slang
   - Fix: minimal pre-configure sed applied replacing -O2 with -Oz
@@ -40,4 +50,5 @@ This document lists recent OFLAG (optimization flag) fixes applied in the reposi
 
 Notes & next steps
 - .bak files left in the build trees are artifacts of the reversible sed step; remove them for cleanliness if desired or keep them as audit evidence.
+- cryptsetup (legacy module) restored to HEAD and is not referenced by any boards; no packaging-time changes are required for that module.
 - For cross-arch completeness, consider running per-package V=1 builds on additional arches (arm64, riscv) for packages that still show legacy -O tokens in non-built files.

modules/cryptsetup2

@@ -18,7 +18,7 @@ cryptsetup2_configure := \
 	( \
 		sed -i 's/hardcode_into_libs=yes/hardcode_into_libs=no/g' configure || true; \
 		sed -i 's/-O3//g' lib/crypto_backend/argon2/*.am lib/crypto_backend/argon2/Makemodule.am || true; \
-		sed -E -i.bak 's/hardcode_libdir_flag_spec=.*/hardcode_libdir_flag_spec=" "/g' configure Makefile.in || true; \
+		sed -E -i 's/hardcode_libdir_flag_spec=.*/hardcode_libdir_flag_spec=" "/g' configure Makefile.in || true; \
 	) && $(CROSS_TOOLS) \
 	CFLAGS="-Oz" \
 	./configure \