Skip to content

Commit 74b7249

Browse files
committed
cbfs/image_test: fix up test cases
This comments out parts of a broken test, leaving a FIXME. Signed-off-by: Daniel Maslowski <info@orangecms.org>
1 parent 82473da commit 74b7249

1 file changed

Lines changed: 27 additions & 24 deletions

File tree

pkg/cbfs/image_test.go

Lines changed: 27 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ func TestBogusArchives(t *testing.T) {
3333
r io.ReadSeeker
3434
want string
3535
}{
36-
{"Short", bytes.NewReader([]byte("INUXARCHIV")), "Cannot find fmap signature"},
37-
{"Misaligned", bytes.NewReader([]byte("INUXARCHIVL")), "Cannot find fmap signature"},
36+
{"Short", bytes.NewReader([]byte("INUXARCHIV")), "cannot find FMAP signature"},
37+
{"Misaligned", bytes.NewReader([]byte("INUXARCHIVL")), "cannot find FMAP signature"},
3838
}
3939

4040
for _, tc := range tests {
@@ -166,27 +166,30 @@ func TestRemovePayload(t *testing.T) {
166166
t.Fatal(err)
167167
}
168168
t.Logf("output file %v", fi)
169-
f, err = os.Open("testdata/removepayload.rom")
170-
if err != nil {
171-
t.Fatal(err)
172-
}
173-
old, err := NewImage(f)
174-
if err != nil {
175-
t.Fatal(err)
176-
}
177-
f.Close()
178-
f, err = os.Open(out.Name())
179-
if err != nil {
180-
t.Fatalf("%s: %v", out.Name(), err)
181-
}
182-
new, err := NewImage(f)
183-
if err != nil {
184-
t.Fatalf("%s: %v", out.Name(), err)
185-
}
186-
f.Close()
187-
if !reflect.DeepEqual(old, new) {
188-
t.Errorf("testdata/coreboot.rom and %s differ", out.Name())
189-
}
190-
t.Logf("new image is %s", new.String())
169+
// FIXME: What is this supposed to do? `removepayload.rom` does not exist
170+
/*
171+
f, err = os.Open("testdata/removepayload.rom")
172+
if err != nil {
173+
t.Fatal(err)
174+
}
175+
old, err := NewImage(f)
176+
if err != nil {
177+
t.Fatal(err)
178+
}
179+
f.Close()
180+
f, err = os.Open(out.Name())
181+
if err != nil {
182+
t.Fatalf("%s: %v", out.Name(), err)
183+
}
184+
new, err := NewImage(f)
185+
if err != nil {
186+
t.Fatalf("%s: %v", out.Name(), err)
187+
}
188+
f.Close()
189+
if !reflect.DeepEqual(old, new) {
190+
t.Errorf("testdata/coreboot.rom and %s differ", out.Name())
191+
}
192+
t.Logf("new image is %s", new.String())
193+
*/
191194

192195
}

0 commit comments

Comments
 (0)