Skip to content

Commit ef2aa9f

Browse files
mpegregkh
authored andcommitted
crypto: vmx - Remove overly verbose printk from AES init routines
commit 1411b52 upstream. In the vmx AES init routines we do a printk(KERN_INFO ...) to report the fallback implementation we're using. However with a slow console this can significantly affect the speed of crypto operations. Using 'cryptsetup benchmark' the removal of the printk() leads to a ~5x speedup for aes-cbc decryption. So remove them. Fixes: 8676590 ("crypto: vmx - Adding AES routines for VMX module") Fixes: 8c755ac ("crypto: vmx - Adding CBC routines for VMX module") Fixes: 4f7f60d ("crypto: vmx - Adding CTR routines for VMX module") Fixes: cc333cd ("crypto: vmx - Adding GHASH routines for VMX module") Cc: stable@vger.kernel.org # v4.1+ Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 05ca7fe commit ef2aa9f

4 files changed

Lines changed: 0 additions & 8 deletions

File tree

drivers/crypto/vmx/aes.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ static int p8_aes_init(struct crypto_tfm *tfm)
5353
alg, PTR_ERR(fallback));
5454
return PTR_ERR(fallback);
5555
}
56-
printk(KERN_INFO "Using '%s' as fallback implementation.\n",
57-
crypto_tfm_alg_driver_name((struct crypto_tfm *) fallback));
5856

5957
crypto_cipher_set_flags(fallback,
6058
crypto_cipher_get_flags((struct

drivers/crypto/vmx/aes_cbc.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ static int p8_aes_cbc_init(struct crypto_tfm *tfm)
5555
alg, PTR_ERR(fallback));
5656
return PTR_ERR(fallback);
5757
}
58-
printk(KERN_INFO "Using '%s' as fallback implementation.\n",
59-
crypto_tfm_alg_driver_name((struct crypto_tfm *) fallback));
6058

6159
crypto_blkcipher_set_flags(
6260
fallback,

drivers/crypto/vmx/aes_ctr.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ static int p8_aes_ctr_init(struct crypto_tfm *tfm)
5353
alg, PTR_ERR(fallback));
5454
return PTR_ERR(fallback);
5555
}
56-
printk(KERN_INFO "Using '%s' as fallback implementation.\n",
57-
crypto_tfm_alg_driver_name((struct crypto_tfm *) fallback));
5856

5957
crypto_blkcipher_set_flags(
6058
fallback,

drivers/crypto/vmx/ghash.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ static int p8_ghash_init_tfm(struct crypto_tfm *tfm)
6464
alg, PTR_ERR(fallback));
6565
return PTR_ERR(fallback);
6666
}
67-
printk(KERN_INFO "Using '%s' as fallback implementation.\n",
68-
crypto_tfm_alg_driver_name(crypto_shash_tfm(fallback)));
6967

7068
crypto_shash_set_flags(fallback,
7169
crypto_shash_get_flags((struct crypto_shash

0 commit comments

Comments
 (0)