Skip to content

Commit eeaed4b

Browse files
Sinan Kayarafaeljw
authored andcommitted
ACPI/PCI/IRQ: assign ISA IRQ directly during early boot stages
We do not want to store the SCI penalty in the acpi_isa_irq_penalty[] table because acpi_isa_irq_penalty[] only holds ISA IRQ penalties and there's no guarantee that the SCI is an ISA IRQ. We add in the SCI penalty as a special case in acpi_irq_get_penalty(). But if we called acpi_penalize_isa_irq() or acpi_irq_penalty_update() for an SCI that happened to be an ISA IRQ, they stored the SCI penalty (part of the acpi_irq_get_penalty() return value) in acpi_isa_irq_penalty[]. Subsequent calls to acpi_irq_get_penalty() returned a penalty that included *two* SCI penalties. Fixes: 103544d (ACPI,PCI,IRQ: reduce resource requirements) Signed-off-by: Sinan Kaya <okaya@codeaurora.org> Acked-by: Bjorn Helgaas <bhelgaas@google.com> Tested-by: Jonathan Liu <net147@gmail.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 07d9a38 commit eeaed4b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/acpi/pci_link.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -849,7 +849,7 @@ static int __init acpi_irq_penalty_update(char *str, int used)
849849
continue;
850850

851851
if (used)
852-
new_penalty = acpi_irq_get_penalty(irq) +
852+
new_penalty = acpi_isa_irq_penalty[irq] +
853853
PIRQ_PENALTY_ISA_USED;
854854
else
855855
new_penalty = 0;
@@ -871,7 +871,7 @@ static int __init acpi_irq_penalty_update(char *str, int used)
871871
void acpi_penalize_isa_irq(int irq, int active)
872872
{
873873
if ((irq >= 0) && (irq < ARRAY_SIZE(acpi_isa_irq_penalty)))
874-
acpi_isa_irq_penalty[irq] = acpi_irq_get_penalty(irq) +
874+
acpi_isa_irq_penalty[irq] +=
875875
(active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING);
876876
}
877877

0 commit comments

Comments
 (0)