Skip to content

Commit e7cb08e

Browse files
Dan Carpentermartinkpetersen
authored andcommitted
scsi: zfcp: spin_lock_irqsave() is not nestable
We accidentally overwrite the original saved value of "flags" so that we can't re-enable IRQs at the end of the function. Presumably this function is mostly called with IRQs disabled or it would be obvious in testing. Fixes: aceeffb ("zfcp: trace full payload of all SAN records (req,resp,iels)") Cc: <stable@vger.kernel.org> #2.6.38+ Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 03eb6b8 commit e7cb08e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/s390/scsi/zfcp_dbf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ void zfcp_dbf_san(char *tag, struct zfcp_dbf *dbf,
384384
/* if (len > rec_len):
385385
* dump data up to cap_len ignoring small duplicate in rec->payload
386386
*/
387-
spin_lock_irqsave(&dbf->pay_lock, flags);
387+
spin_lock(&dbf->pay_lock);
388388
memset(payload, 0, sizeof(*payload));
389389
memcpy(payload->area, paytag, ZFCP_DBF_TAG_LEN);
390390
payload->fsf_req_id = req_id;

0 commit comments

Comments
 (0)