spi: atmel-quadspi.c: Fix warn: passing zero to 'PTR_ERR'

ambarus · duraikvddp · commit e3c0f88dc3bb · 2024-02-05T11:29:27.000+05:30
Fix warn: passing zero to 'PTR_ERR' in atmel_qspi_dma_init().

Signed-off-by: Tudor Ambarus &lt;tudor.ambarus@microchip.com&gt;
diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
@@ -1246,8 +1246,9 @@ static int atmel_qspi_dma_init(struct spi_controller *ctrl)
 
 	aq->rx_chan = dma_request_chan(&aq->pdev->dev, "rx");
 	if (IS_ERR(aq->rx_chan)) {
+		ret = PTR_ERR(aq->rx_chan);
 		aq->rx_chan = NULL;
-		return dev_err_probe(&aq->pdev->dev, PTR_ERR(aq->rx_chan),
+		return dev_err_probe(&aq->pdev->dev, ret,
 				     "RX DMA channel is not available\n");
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1246,8 +1246,9 @@ static int atmel_qspi_dma_init(struct spi_controller *ctrl)`
`1246`	`1246`
`1247`	`1247`	`aq->rx_chan = dma_request_chan(&aq->pdev->dev, "rx");`
`1248`	`1248`	`if (IS_ERR(aq->rx_chan)) {`
	`1249`	`+ ret = PTR_ERR(aq->rx_chan);`
`1249`	`1250`	`aq->rx_chan = NULL;`
`1250`		`- return dev_err_probe(&aq->pdev->dev, PTR_ERR(aq->rx_chan),`
	`1251`	`+ return dev_err_probe(&aq->pdev->dev, ret,`
`1251`	`1252`	`"RX DMA channel is not available\n");`
`1252`	`1253`	`}`
`1253`	`1254`