Input: soc_button_array - silence -ENOENT error on Dell XPS13 9365

jwrdegoede · dtor · commit d912366a59c5 · 2017-08-20T09:30:23.000-07:00
The Dell XPS13 9365 has an INT33D2 ACPI node with no GPIOs, causing the following error in dmesg: [ 7.172275] soc_button_array: probe of INT33D2:00 failed with error -2 This commit silences this, by returning -ENODEV when there are no GPIOs. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196679 Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
@@ -331,7 +331,7 @@ static int soc_button_probe(struct platform_device *pdev)
 	error = gpiod_count(dev, NULL);
 	if (error < 0) {
 		dev_dbg(dev, "no GPIO attached, ignoring...\n");
-		return error;
+		return -ENODEV;
 	}
 
 	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);

Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,7 @@ static int soc_button_probe(struct platform_device *pdev)`
`331`	`331`	`error = gpiod_count(dev, NULL);`
`332`	`332`	`if (error < 0) {`
`333`	`333`	`dev_dbg(dev, "no GPIO attached, ignoring...\n");`
`334`		`- return error;`
	`334`	`+ return -ENODEV;`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);`