PM / clk: signedness bug in of_pm_clk_add_clks()

Dan Carpenter · gregkh · commit d2a97eba0c4e · 2018-09-05T09:26:42.000+02:00
commit 5e2e2f9 upstream. "count" needs to be signed for the error handling to work. I made "i" signed as well so they match. Fixes: 02113ba (PM / clk: Add support for obtaining clocks from device-tree) Cc: 4.6+ <stable@vger.kernel.org> # 4.6+ Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
@@ -185,7 +185,7 @@ EXPORT_SYMBOL_GPL(of_pm_clk_add_clk);
 int of_pm_clk_add_clks(struct device *dev)
 {
 	struct clk **clks;
-	unsigned int i, count;
+	int i, count;
 	int ret;
 
 	if (!dev || !dev->of_node)

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ EXPORT_SYMBOL_GPL(of_pm_clk_add_clk);`
`185`	`185`	`int of_pm_clk_add_clks(struct device *dev)`
`186`	`186`	`{`
`187`	`187`	`struct clk **clks;`
`188`		`- unsigned int i, count;`
	`188`	`+ int i, count;`
`189`	`189`	`int ret;`
`190`	`190`
`191`	`191`	`if (!dev \|\| !dev->of_node)`