Skip to content

Commit cdff57f

Browse files
geertuConchuOD
authored andcommitted
riscv: dts: microchip: mpfs: Fix reference clock node
"make dtbs_check" reports: arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dt.yaml: soc: refclk: {'compatible': ['fixed-clock'], '#clock-cells': [[0]], 'clock-frequency': [[600000000]], 'clock-output-names': ['msspllclk'], 'phandle': [[7]]} should not be valid under {'type': 'object'} From schema: dtschema/schemas/simple-bus.yaml Fix this by moving the node out of the "soc" subnode. While at it, rename it to "msspllclk", and drop the now superfluous "clock-output-names" property. Move the actual clock-frequency value to the board DTS, since it is not set until bitstream programming time. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Tested-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
1 parent f14753a commit cdff57f

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@
4040
};
4141
};
4242

43+
&refclk {
44+
clock-frequency = <600000000>;
45+
};
46+
4347
&serial0 {
4448
status = "okay";
4549
};

arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,11 @@
139139
};
140140
};
141141

142+
refclk: msspllclk {
143+
compatible = "fixed-clock";
144+
#clock-cells = <0>;
145+
};
146+
142147
soc {
143148
#address-cells = <2>;
144149
#size-cells = <2>;
@@ -188,13 +193,6 @@
188193
#dma-cells = <1>;
189194
};
190195

191-
refclk: refclk {
192-
compatible = "fixed-clock";
193-
#clock-cells = <0>;
194-
clock-frequency = <600000000>;
195-
clock-output-names = "msspllclk";
196-
};
197-
198196
clkcfg: clkcfg@20002000 {
199197
compatible = "microchip,mpfs-clkcfg";
200198
reg = <0x0 0x20002000 0x0 0x1000>;

0 commit comments

Comments
 (0)