Skip to content

Commit c7a440c

Browse files
paligregkh
authored andcommitted
PCI: aardvark: Fix PCIe Max Payload Size setting
commit a4e17d6 upstream. Change PCIe Max Payload Size setting in PCIe Device Control register to 512 bytes to align with PCIe Link Initialization sequence as defined in Marvell Armada 3700 Functional Specification. According to the specification, maximal Max Payload Size supported by this device is 512 bytes. Without this kernel prints suspicious line: pci 0000:01:00.0: Upstream bridge's Max Payload Size set to 256 (was 16384, max 512) With this change it changes to: pci 0000:01:00.0: Upstream bridge's Max Payload Size set to 256 (was 512, max 512) Link: https://lore.kernel.org/r/20211005180952.6812-3-kabel@kernel.org Fixes: 8c39d71 ("PCI: aardvark: Add Aardvark PCI host controller driver") Signed-off-by: Pali Rohár <pali@kernel.org> Signed-off-by: Marek Behún <kabel@kernel.org> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Reviewed-by: Marek Behún <kabel@kernel.org> Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f967d12 commit c7a440c

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/pci/controller/pci-aardvark.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,8 +597,9 @@ static void advk_pcie_setup_hw(struct advk_pcie *pcie)
597597
reg = advk_readl(pcie, PCIE_CORE_PCIEXP_CAP + PCI_EXP_DEVCTL);
598598
reg &= ~PCI_EXP_DEVCTL_RELAX_EN;
599599
reg &= ~PCI_EXP_DEVCTL_NOSNOOP_EN;
600+
reg &= ~PCI_EXP_DEVCTL_PAYLOAD;
600601
reg &= ~PCI_EXP_DEVCTL_READRQ;
601-
reg |= PCI_EXP_DEVCTL_PAYLOAD; /* Set max payload size */
602+
reg |= PCI_EXP_DEVCTL_PAYLOAD_512B;
602603
reg |= PCI_EXP_DEVCTL_READRQ_512B;
603604
advk_writel(pcie, reg, PCIE_CORE_PCIEXP_CAP + PCI_EXP_DEVCTL);
604605

0 commit comments

Comments
 (0)