Skip to content

Commit c35ce3d

Browse files
Loic Poulaingregkh
authored andcommitted
net: qrtr: Fix port ID for control messages
[ Upstream commit ae068f5 ] The port ID for control messages was uncorrectly set with broadcast node ID value, causing message to be dropped on remote side since not passing packet filtering (cb->dst_port != QRTR_PORT_CTRL). Fixes: d27e77a ("net: qrtr: Reset the node and port ID of broadcast messages") Signed-off-by: Loic Poulain <loic.poulain@linaro.org> Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent f49731d commit c35ce3d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/qrtr/qrtr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ static int qrtr_node_enqueue(struct qrtr_node *node, struct sk_buff *skb,
187187
hdr->src_port_id = cpu_to_le32(from->sq_port);
188188
if (to->sq_port == QRTR_PORT_CTRL) {
189189
hdr->dst_node_id = cpu_to_le32(node->nid);
190-
hdr->dst_port_id = cpu_to_le32(QRTR_NODE_BCAST);
190+
hdr->dst_port_id = cpu_to_le32(QRTR_PORT_CTRL);
191191
} else {
192192
hdr->dst_node_id = cpu_to_le32(to->sq_node);
193193
hdr->dst_port_id = cpu_to_le32(to->sq_port);

0 commit comments

Comments
 (0)