Skip to content

Commit c1aa0c8

Browse files
YueHaibinggregkh
authored andcommitted
video: fbdev: pxafb: Fix "WARNING: invalid free of devm_ allocated data"
commit 2607391 upstream. 'info->modes' got allocated with devm_kcalloc in of_get_pxafb_display. This gives this error message: ./drivers/video/fbdev/pxafb.c:2238:2-7: WARNING: invalid free of devm_ allocated data Fixes: c8f9630 ("video: fbdev: pxafb: switch to devm_* API") Cc: stable@kernel.org [v4.19+] Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Daniel Mack <daniel@zonque.org> Cc: Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 9797226 commit c1aa0c8

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/video/fbdev/pxafb.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2234,10 +2234,8 @@ static struct pxafb_mach_info *of_pxafb_of_mach_info(struct device *dev)
22342234
if (!info)
22352235
return ERR_PTR(-ENOMEM);
22362236
ret = of_get_pxafb_mode_info(dev, info);
2237-
if (ret) {
2238-
kfree(info->modes);
2237+
if (ret)
22392238
return ERR_PTR(ret);
2240-
}
22412239

22422240
/*
22432241
* On purpose, neither lccrX registers nor video memory size can be

0 commit comments

Comments
 (0)