Skip to content

Commit a51b7cc

Browse files
bjdooks-ctrichardweinberger
authored andcommitted
ubi: pr_err() strings should end with newlines
In ubi_attach_mtd_dev() the pr_err() calls should have their messgaes terminated with a new-line to avoid other messages being concatenated onto the end. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> Signed-off-by: Richard Weinberger <richard@nod.at>
1 parent 278f31a commit a51b7cc

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/mtd/ubi/build.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -825,7 +825,7 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
825825
for (i = 0; i < UBI_MAX_DEVICES; i++) {
826826
ubi = ubi_devices[i];
827827
if (ubi && mtd->index == ubi->mtd->index) {
828-
pr_err("ubi: mtd%d is already attached to ubi%d",
828+
pr_err("ubi: mtd%d is already attached to ubi%d\n",
829829
mtd->index, i);
830830
return -EEXIST;
831831
}
@@ -840,7 +840,7 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
840840
* no sense to attach emulated MTD devices, so we prohibit this.
841841
*/
842842
if (mtd->type == MTD_UBIVOLUME) {
843-
pr_err("ubi: refuse attaching mtd%d - it is already emulated on top of UBI",
843+
pr_err("ubi: refuse attaching mtd%d - it is already emulated on top of UBI\n",
844844
mtd->index);
845845
return -EINVAL;
846846
}
@@ -851,7 +851,7 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
851851
if (!ubi_devices[ubi_num])
852852
break;
853853
if (ubi_num == UBI_MAX_DEVICES) {
854-
pr_err("ubi: only %d UBI devices may be created",
854+
pr_err("ubi: only %d UBI devices may be created\n",
855855
UBI_MAX_DEVICES);
856856
return -ENFILE;
857857
}
@@ -861,7 +861,7 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
861861

862862
/* Make sure ubi_num is not busy */
863863
if (ubi_devices[ubi_num]) {
864-
pr_err("ubi: ubi%i already exists", ubi_num);
864+
pr_err("ubi: ubi%i already exists\n", ubi_num);
865865
return -EEXIST;
866866
}
867867
}

0 commit comments

Comments
 (0)