Skip to content

Commit a2a3370

Browse files
committed
Revert "net: macb: fix for suspend-to-mem feature"
This reverts commit 0c717f6.
1 parent 0c717f6 commit a2a3370

1 file changed

Lines changed: 2 additions & 12 deletions

File tree

drivers/net/ethernet/cadence/macb_main.c

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1884,23 +1884,14 @@ static void macb_reset_hw(struct macb *bp)
18841884
{
18851885
struct macb_queue *queue;
18861886
unsigned int q;
1887-
unsigned long ctrl;
1888-
1889-
/*
1890-
* Be careful to not disable port management, it seems that some
1891-
* PHYs don't like it.
1892-
*/
1893-
ctrl = macb_readl(bp, NCR);
18941887

18951888
/* Disable RX and TX (XXX: Should we halt the transmission
18961889
* more gracefully?)
18971890
*/
1898-
ctrl &= ~(MACB_BIT(RE) | MACB_BIT(TE));
1899-
macb_writel(bp, NCR, ctrl);
1891+
macb_writel(bp, NCR, 0);
19001892

19011893
/* Clear the stats registers (XXX: Update stats first?) */
1902-
ctrl |= MACB_BIT(CLRSTAT);
1903-
macb_writel(bp, NCR, ctrl);
1894+
macb_writel(bp, NCR, MACB_BIT(CLRSTAT));
19041895

19051896
/* Clear all status flags */
19061897
macb_writel(bp, TSR, -1);
@@ -3659,7 +3650,6 @@ static int __maybe_unused macb_suspend(struct device *dev)
36593650
macb_writel(bp, WOL, MACB_BIT(MAG));
36603651
enable_irq_wake(bp->queues[0].irq);
36613652
} else {
3662-
bp->suspend.ncfgr = macb_readl(bp, NCFGR);
36633653
if (netif_running(netdev)) {
36643654
macb_close(netdev);
36653655
}

0 commit comments

Comments
 (0)