Skip to content

Commit 9db4f36

Browse files
committed
mm: remove unused variable in memory hotplug
When I removed the per-zone bitlock hashed waitqueues in commit 9dcb8b6 ("mm: remove per-zone hashtable of bitlock waitqueues"), I removed all the magic hotplug memory initialization of said waitqueues too. But when I actually _tested_ the resulting build, I stupidly assumed that "allmodconfig" would enable memory hotplug. And it doesn't, because it enables KASAN instead, which then disables hotplug memory support. As a result, my build test of the per-zone waitqueues was totally broken, and I didn't notice that the compiler warns about the now unused iterator variable 'i'. I guess I should be happy that that seems to be the worst breakage from my clearly horribly failed test coverage. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 4e68af0 commit 9db4f36

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

mm/memory_hotplug.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2117,7 +2117,6 @@ void try_offline_node(int nid)
21172117
unsigned long start_pfn = pgdat->node_start_pfn;
21182118
unsigned long end_pfn = start_pfn + pgdat->node_spanned_pages;
21192119
unsigned long pfn;
2120-
int i;
21212120

21222121
for (pfn = start_pfn; pfn < end_pfn; pfn += PAGES_PER_SECTION) {
21232122
unsigned long section_nr = pfn_to_section_nr(pfn);

0 commit comments

Comments
 (0)