Skip to content

Commit 8d0ead2

Browse files
committed
net: macb: move checksum clearing outside of spinlock
Move checksum clearing outside of spinlock. The SKB is protected by networking lock (HARD_TX_LOCK()). Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 92b6abb commit 8d0ead2

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

drivers/net/ethernet/cadence/macb_main.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1662,6 +1662,11 @@ static netdev_tx_t macb_start_xmit(struct sk_buff *skb, struct net_device *dev)
16621662
bool is_lso, is_udp = 0;
16631663
netdev_tx_t ret = NETDEV_TX_OK;
16641664

1665+
if (macb_clear_csum(skb)) {
1666+
dev_kfree_skb_any(skb);
1667+
return ret;
1668+
}
1669+
16651670
is_lso = (skb_shinfo(skb)->gso_size != 0);
16661671

16671672
if (is_lso) {
@@ -1717,11 +1722,6 @@ static netdev_tx_t macb_start_xmit(struct sk_buff *skb, struct net_device *dev)
17171722
return NETDEV_TX_BUSY;
17181723
}
17191724

1720-
if (macb_clear_csum(skb)) {
1721-
dev_kfree_skb_any(skb);
1722-
goto unlock;
1723-
}
1724-
17251725
/* Map socket buffer for DMA transfer */
17261726
if (!macb_tx_map(bp, queue, skb, hdrlen)) {
17271727
dev_kfree_skb_any(skb);

0 commit comments

Comments
 (0)