Skip to content

Commit 8b8b5f9

Browse files
sudeep-hollagregkh
authored andcommitted
firmware: arm_scmi: Fix doorbell ring logic for !CONFIG_64BIT
[ Upstream commit 7bd39bc ] The logic to ring the scmi performance fastchannel ignores the value read from the doorbell register in case of !CONFIG_64BIT. This bug also shows up as warning with '-Wunused-but-set-variable' gcc flag: drivers/firmware/arm_scmi/perf.c: In function scmi_perf_fc_ring_db: drivers/firmware/arm_scmi/perf.c:323:7: warning: variable val set but not used [-Wunused-but-set-variable] Fix the same by aligning the logic with CONFIG_64BIT as used in the macro SCMI_PERF_FC_RING_DB(). Fixes: 8238395 ("firmware: arm_scmi: Make use SCMI v2.0 fastchannel for performance protocol") Reported-by: Hulk Robot <hulkci@huawei.com> Reported-by: Zheng Yongjun <zhengyongjun3@huawei.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 83ff921 commit 8b8b5f9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/firmware/arm_scmi

drivers/firmware/arm_scmi/perf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ static void scmi_perf_fc_ring_db(struct scmi_fc_db_info *db)
323323

324324
if (db->mask)
325325
val = ioread64_hi_lo(db->addr) & db->mask;
326-
iowrite64_hi_lo(db->set, db->addr);
326+
iowrite64_hi_lo(db->set | val, db->addr);
327327
}
328328
#endif
329329
}

0 commit comments

Comments
 (0)