Skip to content

Commit 8b34a7b

Browse files
raven-augregkh
authored andcommitted
autofs: fix autofs_sbi() does not check super block type
commit 0633da4 upstream. autofs_sbi() does not check the superblock magic number to verify it has been given an autofs super block. Backport Note: autofs4 has been renamed to autofs upstream. As a result the upstream patch does not apply cleanly onto 4.14.y. Link: http://lkml.kernel.org/r/153475422934.17131.7563724552005298277.stgit@pluto.themaw.net Reported-by: <syzbot+87c3c541582e56943277@syzkaller.appspotmail.com> Signed-off-by: Ian Kent <raven@themaw.net> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Zubin Mithra <zsm@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent daf0ca7 commit 8b34a7b

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

fs/autofs4/autofs_i.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include <linux/list.h>
2727
#include <linux/completion.h>
2828
#include <asm/current.h>
29+
#include <linux/magic.h>
2930

3031
/* This is the range of ioctl() numbers we claim as ours */
3132
#define AUTOFS_IOC_FIRST AUTOFS_IOC_READY
@@ -124,7 +125,8 @@ struct autofs_sb_info {
124125

125126
static inline struct autofs_sb_info *autofs4_sbi(struct super_block *sb)
126127
{
127-
return (struct autofs_sb_info *)(sb->s_fs_info);
128+
return sb->s_magic != AUTOFS_SUPER_MAGIC ?
129+
NULL : (struct autofs_sb_info *)(sb->s_fs_info);
128130
}
129131

130132
static inline struct autofs_info *autofs4_dentry_ino(struct dentry *dentry)

fs/autofs4/inode.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include <linux/pagemap.h>
1515
#include <linux/parser.h>
1616
#include <linux/bitops.h>
17-
#include <linux/magic.h>
1817
#include "autofs_i.h"
1918
#include <linux/module.h>
2019

0 commit comments

Comments
 (0)