scsi: ibmvscsis: Fix write_pending failure path

Bryant G. Ly · martinkpetersen · commit 88e65389fce1 · 2017-10-02T22:49:27.000-04:00
For write_pending if the queue is down or client failed then return -EIO so that LIO can properly process the completed command. Prior we returned 0 since LIO could not handle it properly. Now with commit fa7e25c ("target: Fix unknown fabric callback queue-full errors") that patch addresses LIO's ability to handle things right. Signed-off-by: Bryant G. Ly <bgly@us.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -3767,7 +3767,7 @@ static int ibmvscsis_write_pending(struct se_cmd *se_cmd)
 	 */
 	if ((vscsi->flags & (CLIENT_FAILED | RESPONSE_Q_DOWN))) {
 		pr_err("write_pending failed since: %d\n", vscsi->flags);
-		return 0;
+		return -EIO;
 	}
 
 	rc = srp_transfer_data(cmd, &vio_iu(iue)->srp.cmd, ibmvscsis_rdma,

Original file line number	Diff line number	Diff line change
`@@ -3767,7 +3767,7 @@ static int ibmvscsis_write_pending(struct se_cmd *se_cmd)`
`3767`	`3767`	`*/`
`3768`	`3768`	`if ((vscsi->flags & (CLIENT_FAILED \| RESPONSE_Q_DOWN))) {`
`3769`	`3769`	`pr_err("write_pending failed since: %d\n", vscsi->flags);`
`3770`		`- return 0;`
	`3770`	`+ return -EIO;`
`3771`	`3771`	`}`
`3772`	`3772`
`3773`	`3773`	`rc = srp_transfer_data(cmd, &vio_iu(iue)->srp.cmd, ibmvscsis_rdma,`