i2c: slave: add sanity check when unregistering

Wolfram Sang · gregkh · commit 871b5a5a3be9 · 2020-08-11T15:33:37.000+02:00
[ Upstream commit 8808981 ] Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Alain Volmat <alain.volmat@st.com> Signed-off-by: Wolfram Sang <wsa@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/i2c/i2c-core-slave.c b/drivers/i2c/i2c-core-slave.c
@@ -58,6 +58,9 @@ int i2c_slave_unregister(struct i2c_client *client)
 {
 	int ret;
 
+	if (IS_ERR_OR_NULL(client))
+		return -EINVAL;
+
 	if (!client->adapter->algo->unreg_slave) {
 		dev_err(&client->dev, "%s: not supported by adapter\n", __func__);
 		return -EOPNOTSUPP;

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,9 @@ int i2c_slave_unregister(struct i2c_client *client)`
`58`	`58`	`{`
`59`	`59`	`int ret;`
`60`	`60`
	`61`	`+ if (IS_ERR_OR_NULL(client))`
	`62`	`+ return -EINVAL;`
	`63`	`+`
`61`	`64`	`if (!client->adapter->algo->unreg_slave) {`
`62`	`65`	`dev_err(&client->dev, "%s: not supported by adapter\n", __func__);`
`63`	`66`	`return -EOPNOTSUPP;`