Skip to content

Commit 86f4bc1

Browse files
committed
Merge branch 'at91-4.19-trunk/base_nand' into linux-4.19-at91
2 parents 7e500d7 + 812feb9 commit 86f4bc1

1 file changed

Lines changed: 15 additions & 6 deletions

File tree

drivers/mtd/nand/raw/atmel/pmecc.c

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -870,23 +870,32 @@ static struct atmel_pmecc *atmel_pmecc_get_by_node(struct device *userdev,
870870
{
871871
struct platform_device *pdev;
872872
struct atmel_pmecc *pmecc, **ptr;
873+
int ret;
873874

874875
pdev = of_find_device_by_node(np);
875-
if (!pdev || !platform_get_drvdata(pdev))
876+
if (!pdev)
876877
return ERR_PTR(-EPROBE_DEFER);
878+
pmecc = platform_get_drvdata(pdev);
879+
if (!pmecc) {
880+
ret = -EPROBE_DEFER;
881+
goto err_put_device;
882+
}
877883

878884
ptr = devres_alloc(devm_atmel_pmecc_put, sizeof(*ptr), GFP_KERNEL);
879-
if (!ptr)
880-
return ERR_PTR(-ENOMEM);
881-
882-
get_device(&pdev->dev);
883-
pmecc = platform_get_drvdata(pdev);
885+
if (!ptr) {
886+
ret = -ENOMEM;
887+
goto err_put_device;
888+
}
884889

885890
*ptr = pmecc;
886891

887892
devres_add(userdev, ptr);
888893

889894
return pmecc;
895+
896+
err_put_device:
897+
put_device(&pdev->dev);
898+
return ERR_PTR(ret);
890899
}
891900

892901
static const int atmel_pmecc_strengths[] = { 2, 4, 8, 12, 24, 32 };

0 commit comments

Comments
 (0)