ACPI / APEI: Fix incorrect return value of ghes_proc()

punitagrawal · rafaeljw · commit 806487a8fc8f · 2016-10-24T14:32:14.000+02:00
Although ghes_proc() tests for errors while reading the error status, it always return success (0). Fix this by propagating the return value. Fixes: d334a49 (ACPI, APEI, Generic Hardware Error Source memory error support) Signed-of-by: Punit Agrawal <punit.agrawa.@arm.com> Tested-by: Tyler Baicar <tbaicar@codeaurora.org> Reviewed-by: Borislav Petkov <bp@suse.de> [ rjw: Subject ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
@@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes)
 	ghes_do_proc(ghes, ghes->estatus);
 out:
 	ghes_clear_estatus(ghes);
-	return 0;
+	return rc;
 }
 
 static void ghes_add_timer(struct ghes *ghes)

Original file line number	Diff line number	Diff line change
`@@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes)`
`662`	`662`	`ghes_do_proc(ghes, ghes->estatus);`
`663`	`663`	`out:`
`664`	`664`	`ghes_clear_estatus(ghes);`
`665`		`- return 0;`
	`665`	`+ return rc;`
`666`	`666`	`}`
`667`	`667`
`668`	`668`	`static void ghes_add_timer(struct ghes *ghes)`