Skip to content

Commit 78b1cb3

Browse files
djbwgregkh
authored andcommitted
mm: fail get_vaddr_frames() for filesystem-dax mappings
commit b7f0554 upstream. Until there is a solution to the dma-to-dax vs truncate problem it is not safe to allow V4L2, Exynos, and other frame vector users to create long standing / irrevocable memory registrations against filesytem-dax vmas. [dan.j.williams@intel.com: add comment for vma_is_fsdax() check in get_vaddr_frames(), per Jan] Link: http://lkml.kernel.org/r/151197874035.26211.4061781453123083667.stgit@dwillia2-desk3.amr.corp.intel.com Link: http://lkml.kernel.org/r/151068939985.7446.15684639617389154187.stgit@dwillia2-desk3.amr.corp.intel.com Fixes: 3565fce ("mm, x86: get_user_pages() for dax mappings") Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Jan Kara <jack@suse.cz> Cc: Inki Dae <inki.dae@samsung.com> Cc: Seung-Woo Kim <sw0312.kim@samsung.com> Cc: Joonyoung Shim <jy0922.shim@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Mel Gorman <mgorman@suse.de> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Christoph Hellwig <hch@lst.de> Cc: Doug Ledford <dledford@redhat.com> Cc: Hal Rosenstock <hal.rosenstock@gmail.com> Cc: Jason Gunthorpe <jgg@mellanox.com> Cc: Jeff Moyer <jmoyer@redhat.com> Cc: Ross Zwisler <ross.zwisler@linux.intel.com> Cc: Sean Hefty <sean.hefty@intel.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 8f7cf88 commit 78b1cb3

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

mm/frame_vector.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,18 @@ int get_vaddr_frames(unsigned long start, unsigned int nr_frames,
5252
ret = -EFAULT;
5353
goto out;
5454
}
55+
56+
/*
57+
* While get_vaddr_frames() could be used for transient (kernel
58+
* controlled lifetime) pinning of memory pages all current
59+
* users establish long term (userspace controlled lifetime)
60+
* page pinning. Treat get_vaddr_frames() like
61+
* get_user_pages_longterm() and disallow it for filesystem-dax
62+
* mappings.
63+
*/
64+
if (vma_is_fsdax(vma))
65+
return -EOPNOTSUPP;
66+
5567
if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) {
5668
vec->got_ref = true;
5769
vec->is_pfns = false;

0 commit comments

Comments
 (0)