pwm: atmel: Free resources only after pwmchip_remove()

Uwe Kleine-König · claudiubeznea · commit 75b589581a6e · 2021-10-28T14:54:09.000+03:00
Before pwmchip_remove() returns the PWM is expected to be functional. So
remove the pwmchip before disabling the clock.

Signed-off-by: Uwe Kleine-König &lt;u.kleine-koenig@pengutronix.de&gt;
Acked-by: Claudiu Beznea &lt;claudiu.beznea@microchip.com&gt;
Signed-off-by: Thierry Reding &lt;thierry.reding@gmail.com&gt;
diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
@@ -450,10 +450,12 @@ static int atmel_pwm_remove(struct platform_device *pdev)
 {
 	struct atmel_pwm_chip *atmel_pwm = platform_get_drvdata(pdev);
 
+	pwmchip_remove(&atmel_pwm->chip);
+
 	clk_unprepare(atmel_pwm->clk);
 	mutex_destroy(&atmel_pwm->isr_lock);
 
-	return pwmchip_remove(&atmel_pwm->chip);
+	return 0;
 }
 
 static struct platform_driver atmel_pwm_driver = {

Original file line number	Diff line number	Diff line change
`@@ -450,10 +450,12 @@ static int atmel_pwm_remove(struct platform_device *pdev)`
`450`	`450`	`{`
`451`	`451`	`struct atmel_pwm_chip *atmel_pwm = platform_get_drvdata(pdev);`
`452`	`452`
	`453`	`+ pwmchip_remove(&atmel_pwm->chip);`
	`454`	`+`
`453`	`455`	`clk_unprepare(atmel_pwm->clk);`
`454`	`456`	`mutex_destroy(&atmel_pwm->isr_lock);`
`455`	`457`
`456`		`- return pwmchip_remove(&atmel_pwm->chip);`
	`458`	`+ return 0;`
`457`	`459`	`}`
`458`	`460`
`459`	`461`	`static struct platform_driver atmel_pwm_driver = {`