Skip to content

Commit 74784da

Browse files
committed
Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf
Pablo Neira Ayuso says: ==================== Netfilter fixes for net The following patchset contains two one-liner fixes for your net tree, they are: 1) Disable fast hash operations for 2-bytes length keys which is leading to incorrect lookups in nf_tables, from Anatole Denis. 2) Reload pointer ipv4 header after ip_route_me_harder() given this may result in use-after-free due to skbuff header reallocation, patch from Tejaswi Tanikella. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
2 parents 18129a2 + 7400bb4 commit 74784da

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

net/ipv4/netfilter/nf_reject_ipv4.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ void nf_send_reset(struct net *net, struct sk_buff *oldskb, int hook)
132132
if (ip_route_me_harder(net, nskb, RTN_UNSPEC))
133133
goto free_nskb;
134134

135+
niph = ip_hdr(nskb);
136+
135137
/* "Never happens" */
136138
if (nskb->len > dst_mtu(skb_dst(nskb)))
137139
goto free_nskb;

net/netfilter/nft_set_hash.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,6 @@ nft_hash_select_ops(const struct nft_ctx *ctx, const struct nft_set_desc *desc,
643643
{
644644
if (desc->size) {
645645
switch (desc->klen) {
646-
case 2:
647646
case 4:
648647
return &nft_hash_fast_ops;
649648
default:

0 commit comments

Comments
 (0)