Skip to content

Commit 69e2d1e

Browse files
Varun Prakashmartinkpetersen
authored andcommitted
scsi: libcxgbi: fix incorrect DDP resource cleanup
Before calling task_release_itt() task data is memset to zero because of which DDP context information is lost resulting in incorrect DDP resource cleanup, to fix this call task_release_itt() before memset. Signed-off-by: Varun Prakash <varun@chelsio.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent a5dd506 commit 69e2d1e

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/scsi/cxgbi/libcxgbi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2081,9 +2081,10 @@ void cxgbi_cleanup_task(struct iscsi_task *task)
20812081
/* never reached the xmit task callout */
20822082
if (tdata->skb)
20832083
__kfree_skb(tdata->skb);
2084-
memset(tdata, 0, sizeof(*tdata));
20852084

20862085
task_release_itt(task, task->hdr_itt);
2086+
memset(tdata, 0, sizeof(*tdata));
2087+
20872088
iscsi_tcp_cleanup_task(task);
20882089
}
20892090
EXPORT_SYMBOL_GPL(cxgbi_cleanup_task);

0 commit comments

Comments
 (0)