Skip to content

Commit 6036160

Browse files
hotranWolfram Sang
authored andcommitted
i2c: xgene: Avoid dma_buffer overrun
SMBus block command uses the first byte of buffer for the data length. The dma_buffer should be increased by 1 to avoid the overrun issue. Reported-by: Phil Endecott <phil_gjouf_endecott@chezphil.org> Signed-off-by: Hoan Tran <hotran@apm.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Cc: stable@kernel.org
1 parent 60a951a commit 6036160

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/i2c/busses/i2c-xgene-slimpro.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ struct slimpro_i2c_dev {
105105
struct mbox_chan *mbox_chan;
106106
struct mbox_client mbox_client;
107107
struct completion rd_complete;
108-
u8 dma_buffer[I2C_SMBUS_BLOCK_MAX];
108+
u8 dma_buffer[I2C_SMBUS_BLOCK_MAX + 1]; /* dma_buffer[0] is used for length */
109109
u32 *resp_msg;
110110
};
111111

0 commit comments

Comments
 (0)